Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 52113002: Roll NSS deps from r228205 --> r231937. (Closed)

Created:
7 years, 1 month ago by eroman
Modified:
7 years, 1 month ago
Reviewers:
agl, wtc, Ryan Sleevi
CC:
chromium-reviews, wtc, agl
Visibility:
Public.

Description

Roll NSS deps from r228205 --> r231937. This picks up four patches: r231937: Update the patch file for r231825 r231825: NSS: Typo fix for non-x86 builds in generic poly1305 code. r231777: Expose PK11_GenerateKeyPairWithOpFlags to Windows build of NSS. r230497: Support ChaCha20+Poly1305 cipher suites. BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232050

Patch Set 1 #

Patch Set 2 : Pick up agl's fix #

Total comments: 1

Patch Set 3 : Update to 231937 #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
eroman
7 years, 1 month ago (2013-10-30 06:42:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/52113002/1
7 years, 1 month ago (2013-10-30 06:43:13 UTC) #2
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-10-30 07:13:54 UTC) #3
eroman
wtc/agl: http://crrev.com/230497: Support ChaCha20+Poly1305 cipher suites. Is failing to compile on ios. Here are two ...
7 years, 1 month ago (2013-10-30 07:24:17 UTC) #4
agl
I thought that the email was reporting a current build break so I submitted https://codereview.chromium.org/51333008 ...
7 years, 1 month ago (2013-10-30 14:21:04 UTC) #5
eroman
Thanks Adam! Giving it a try now
7 years, 1 month ago (2013-10-30 18:23:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/52113002/250001
7 years, 1 month ago (2013-10-30 18:31:42 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-10-30 18:44:18 UTC) #8
wtc
https://codereview.chromium.org/52113002/diff/250001/DEPS File DEPS (right): https://codereview.chromium.org/52113002/diff/250001/DEPS#newcode55 DEPS:55: "nss_revision": "231825", I'd appreciate it if you could change ...
7 years, 1 month ago (2013-10-30 22:06:40 UTC) #9
eroman
wtc: Done
7 years, 1 month ago (2013-10-30 22:10:04 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-10-30 22:13:56 UTC) #11
agl
lgtm
7 years, 1 month ago (2013-10-30 22:18:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/52113002/500001
7 years, 1 month ago (2013-10-30 22:54:33 UTC) #13
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 09:00:20 UTC) #14
Message was sent while issue was closed.
Change committed as 232050

Powered by Google App Engine
This is Rietveld 408576698