Added git footers tool to parse conventional metadata from git commits

Added git footers tool to parse conventional metadata from git commits

BUG=407316
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291777

[luqui, 2014-08-30 00:13:21]

luqui@chromium.org changed reviewers:
+ iannucci@chromium.org

[luqui, 2014-08-30 00:13:21]

ptal

[iannucci, 2014-08-30 00:24:20]

thanks for doing this. could you also add manpage documentation?

cd man/src
make_docs.sh
<git checkout all the spam changes>
edit git-footers.txt _git-footers_desc.helper.txt git-footers.demo.1.sh
make_docs.sh

https://codereview.chromium.org/521033002/diff/1/git_footers.py
File git_footers.py (right):

https://codereview.chromium.org/521033002/diff/1/git_footers.py#newcode28
git_footers.py:28: def parse_footers(log):
this isn't really a log, it's a commit message. name msg and docstring?

https://codereview.chromium.org/521033002/diff/1/git_footers.py#newcode53
git_footers.py:53: '(case insensitive)')
could we also add a special --position, --position_ref, --position_num, which
do:
  * if there's a Cr-Commit-Position, return that (or the parsed ref/num portion)
  * if there's a git-svn-id, determine the effective ref by:
    * if url ends with /chrome/trunk/src 
      * ref -> refs/heads/master
      * num -> svn revision
    * if url ends with /chrome/branches/..../src
      * ref -> refs/branch-heads/....
      * num -> None

https://codereview.chromium.org/521033002/diff/1/git_footers.py#newcode57
git_footers.py:57: log = git.run('log', '-1', opts.ref)
suggest formatting this using --format=%B

[luqui, 2014-09-03 00:08:07]

addressed; ptal

[iannucci, 2014-09-03 00:21:44]

lgtm

https://codereview.chromium.org/521033002/diff/60001/git_footers.py
File git_footers.py (right):

https://codereview.chromium.org/521033002/diff/60001/git_footers.py#newcode68
git_footers.py:68: number can be None if that doesn't make sense (e.g. a
branch).
mention that this falls back to git-svn-id

also... branches have position numbers

https://codereview.chromium.org/521033002/diff/60001/git_footers.py#newcode77
git_footers.py:77: svn_commit = get_unique(footers, 'Git-Svn-Id')
note that it's always git-svn-id, though you're lower()ing, so I guess it
doesn't matter?

https://codereview.chromium.org/521033002/diff/60001/git_footers.py#newcode102
git_footers.py:102: g.add_argument('--position-num', action='store_true')
use an exclusive group for all of these

https://codereview.chromium.org/521033002/diff/60001/git_footers.py#newcode118
git_footers.py:118: print pos[0]
I would actually print it as

  refs/branch-heads/12345@{#0}

https://codereview.chromium.org/521033002/diff/60001/man/src/git-footers.demo...
File man/src/git-footers.demo.1.sh (right):

https://codereview.chromium.org/521033002/diff/60001/man/src/git-footers.demo...
man/src/git-footers.demo.1.sh:6: add modified_file
add . 

may work

[luqui, 2014-09-03 02:28:49]

https://codereview.chromium.org/521033002/diff/60001/git_footers.py
File git_footers.py (right):

https://codereview.chromium.org/521033002/diff/60001/git_footers.py#newcode68
git_footers.py:68: number can be None if that doesn't make sense (e.g. a
branch).
On 2014/09/03 00:21:44, iannucci wrote:
> mention that this falls back to git-svn-id
> 
> also... branches have position numbers

Done.

https://codereview.chromium.org/521033002/diff/60001/git_footers.py#newcode77
git_footers.py:77: svn_commit = get_unique(footers, 'Git-Svn-Id')
On 2014/09/03 00:21:44, iannucci wrote:
> note that it's always git-svn-id, though you're lower()ing, so I guess it
> doesn't matter?

Made it git-svn-id for greppability.

https://codereview.chromium.org/521033002/diff/60001/git_footers.py#newcode102
git_footers.py:102: g.add_argument('--position-num', action='store_true')
On 2014/09/03 00:21:44, iannucci wrote:
> use an exclusive group for all of these

Uh... they already are?

https://codereview.chromium.org/521033002/diff/60001/git_footers.py#newcode118
git_footers.py:118: print pos[0]
On 2014/09/03 00:21:44, iannucci wrote:
> I would actually print it as
> 
>   refs/branch-heads/12345@{#0}

Printing as refs/branch-heads/12345@{#?}

[luqui, 2014-09-03 02:28:58]

The CQ bit was checked by luqui@chromium.org

[commit-bot: I haz the power, 2014-09-03 02:29:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/luqui@chromium.org/521033002/80001

[commit-bot: I haz the power, 2014-09-03 02:31:04]

Committed patchset #5 (id:80001) as 291777