Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 52103004: WebSocket layout test cleanup (Closed)

Created:
7 years, 1 month ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 1 month ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

WebSocket layout test cleanup - Rename "Web Socket" in layout tests - Rephrase comments - Make comments fit 80 col - Fix comment referring old spec hixie-60 BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160931

Patch Set 1 #

Patch Set 2 : yhirano's comment #

Total comments: 4

Patch Set 3 : yhirano's comments #

Patch Set 4 : Rebase #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -47 lines) Patch
M LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/close-on-navigate-new-location.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/close-on-unload.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/close-unref-websocket.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/close-unref-websocket-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/cross-origin.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/cross-origin-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/reload-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/reload-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/resources/close-on-unload-iframe.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/resources/close-on-unload-iframe-reference-in-parent.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/send.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/send-after-close-on-unload.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/send-blob-onmessage-origin.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/send-blob-onmessage-origin-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/send-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/send-onmessage-origin.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/send-onmessage-origin-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/send-throw.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/send-throw-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/simple.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/simple-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/unicode.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/unicode-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/url-parsing.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/useragent-in-openinghandshake.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/useragent-in-openinghandshake-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/workers/close-in-shared-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/workers/close-in-shared-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/workers/close-in-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/workers/close-in-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/workers/shared-worker-simple.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/workers/shared-worker-simple-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/workers/worker-simple.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/tests/hybi/workers/worker-simple-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 1 month ago (2013-10-30 08:36:18 UTC) #1
yhirano
I think send-throw and close-before-open should be fixed as well.
7 years, 1 month ago (2013-10-30 10:42:53 UTC) #2
tyoshino (SeeGerritForStatus)
7 years, 1 month ago (2013-10-30 10:53:51 UTC) #3
tyoshino (SeeGerritForStatus)
On 2013/10/30 10:42:53, yhirano wrote: > I think send-throw and close-before-open should be fixed as ...
7 years, 1 month ago (2013-10-30 10:54:12 UTC) #4
yhirano
lgtm https://codereview.chromium.org/52103004/diff/50001/LayoutTests/http/tests/websocket/tests/hybi/resources/close-on-unload-iframe-reference-in-parent.html File LayoutTests/http/tests/websocket/tests/hybi/resources/close-on-unload-iframe-reference-in-parent.html (right): https://codereview.chromium.org/52103004/diff/50001/LayoutTests/http/tests/websocket/tests/hybi/resources/close-on-unload-iframe-reference-in-parent.html#newcode13 LayoutTests/http/tests/websocket/tests/hybi/resources/close-on-unload-iframe-reference-in-parent.html:13: // send "socket1" to server, so that "socket1" ...
7 years, 1 month ago (2013-10-30 11:35:07 UTC) #5
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/52103004/diff/50001/LayoutTests/http/tests/websocket/tests/hybi/resources/close-on-unload-iframe-reference-in-parent.html File LayoutTests/http/tests/websocket/tests/hybi/resources/close-on-unload-iframe-reference-in-parent.html (right): https://codereview.chromium.org/52103004/diff/50001/LayoutTests/http/tests/websocket/tests/hybi/resources/close-on-unload-iframe-reference-in-parent.html#newcode13 LayoutTests/http/tests/websocket/tests/hybi/resources/close-on-unload-iframe-reference-in-parent.html:13: // send "socket1" to server, so that "socket1" will ...
7 years, 1 month ago (2013-10-30 11:56:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/52103004/130001
7 years, 1 month ago (2013-10-30 11:56:53 UTC) #7
commit-bot: I haz the power
Failed to apply patch for LayoutTests/http/tests/websocket/tests/hybi/close-before-open-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-10-30 11:57:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/52103004/130002
7 years, 1 month ago (2013-10-30 12:32:59 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 13:39:06 UTC) #10
Message was sent while issue was closed.
Change committed as 160931

Powered by Google App Engine
This is Rietveld 408576698