Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 52103003: Remove unused flag from the feature.gypi (Closed)

Created:
7 years, 1 month ago by dw.im
Modified:
7 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unused flag from the feature.gypi Two flags - ENABLE_CSS_EXCLUSIONS and ENABLE_CSS_REGIONS - are not used. Those features use runtime flag rather than compile flag currently. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/build/features.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dw.im
feature.gypi file is the only file that the two flags are alive currently. The flags ...
7 years, 1 month ago (2013-10-30 08:12:43 UTC) #1
abucur
I'm fine with the change. It looks like CSS Regions is just under the "experimental" ...
7 years, 1 month ago (2013-10-30 15:45:30 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-10-30 23:53:36 UTC) #3
leviw_travelin_and_unemployed
lgtm
7 years, 1 month ago (2013-10-31 00:25:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/52103003/1
7 years, 1 month ago (2013-10-31 00:29:19 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 01:43:42 UTC) #6
Message was sent while issue was closed.
Change committed as 160998

Powered by Google App Engine
This is Rietveld 408576698