athena: Show a progress-bar when loading a web-page.

athena: Show a progress-bar when loading a web-page.

BUG=none
R=mukai@chromium.org
TBR=vollick@chromium.org for DEPS addition on //ui/compositor

Committed: https://crrev.com/a596d7b3c51ff8a96be897e1185308fd41f2084f
Cr-Commit-Position: refs/heads/master@{#292793}

[sadrul, 2014-08-30 04:11:39]

sadrul@chromium.org changed reviewers:
+ mukai@chromium.org

[Jun Mukai, 2014-08-30 09:04:18]

https://codereview.chromium.org/521013004/diff/1/athena/content/web_activity.cc
File athena/content/web_activity.cc (right):

https://codereview.chromium.org/521013004/diff/1/athena/content/web_activity....
athena/content/web_activity.cc:271: return;
I think progress_bar_ should be reset here.
Otherwise, loading -> esc to cancel load will keep the progress bar.

https://codereview.chromium.org/521013004/diff/1/athena/content/web_activity....
athena/content/web_activity.cc:282: ui::ScopedLayerAnimationSettings
settings(progress_bar_->GetAnimator());
EASE_IN tween type in this case maybe?
http://www.google.com/design/spec/animation/authentic-motion.html#authentic-m...

[sadrul, 2014-08-30 15:06:49]

https://codereview.chromium.org/521013004/diff/1/athena/content/web_activity.cc
File athena/content/web_activity.cc (right):

https://codereview.chromium.org/521013004/diff/1/athena/content/web_activity....
athena/content/web_activity.cc:271: return;
On 2014/08/30 09:04:18, Jun Mukai wrote:
> I think progress_bar_ should be reset here.
> Otherwise, loading -> esc to cancel load will keep the progress bar.

Cancelling the load triggers a LoadingStateChanged(), which calls
LoadProgressChanged() with progress = 1. (incidentally, it doesn't look like we
have esc to cancel loading in athena:
https://codereview.chromium.org/527473002/)

https://codereview.chromium.org/521013004/diff/1/athena/content/web_activity....
athena/content/web_activity.cc:282: ui::ScopedLayerAnimationSettings
settings(progress_bar_->GetAnimator());
On 2014/08/30 09:04:18, Jun Mukai wrote:
> EASE_IN tween type in this case maybe?
>
http://www.google.com/design/spec/animation/authentic-motion.html#authentic-m...

Done (Thanks for the link! Is there a specific section in that link you are
referring to that mention the animation setting for fade-out?)

[Jun Mukai, 2014-08-30 16:24:18]

lgtm

https://codereview.chromium.org/521013004/diff/1/athena/content/web_activity.cc
File athena/content/web_activity.cc (right):

https://codereview.chromium.org/521013004/diff/1/athena/content/web_activity....
athena/content/web_activity.cc:271: return;
On 2014/08/30 15:06:48, sadrul wrote:
> On 2014/08/30 09:04:18, Jun Mukai wrote:
> > I think progress_bar_ should be reset here.
> > Otherwise, loading -> esc to cancel load will keep the progress bar.
> 
> Cancelling the load triggers a LoadingStateChanged(), which calls
> LoadProgressChanged() with progress = 1. (incidentally, it doesn't look like
we
> have esc to cancel loading in athena:
> https://codereview.chromium.org/527473002/)

cool, I didn't know.

https://codereview.chromium.org/521013004/diff/1/athena/content/web_activity....
athena/content/web_activity.cc:282: ui::ScopedLayerAnimationSettings
settings(progress_bar_->GetAnimator());
On 2014/08/30 15:06:48, sadrul wrote:
> On 2014/08/30 09:04:18, Jun Mukai wrote:
> > EASE_IN tween type in this case maybe?
> >
>
http://www.google.com/design/spec/animation/authentic-motion.html#authentic-m...
> 
> Done (Thanks for the link! Is there a specific section in that link you are
> referring to that mention the animation setting for fade-out?)

I couldn't find the case specifically for fade-out. I think the
'entering-and-ending' can be applied here.

[sadrul, 2014-08-30 16:39:55]

sadrul@chromium.org changed reviewers:
+ vollick@chromium.org

[sadrul, 2014-08-30 16:39:55]

+vollick@ for DEPS addition on ui/compositor (will TBR)

[sadrul, 2014-08-30 16:43:36]

Committed patchset #2 (id:20001) manually as a596d7b (presubmit successful).

[commit-bot: I haz the power, 2014-09-10 03:14:22]

Patchset 2 (id:??) landed as
https://crrev.com/a596d7b3c51ff8a96be897e1185308fd41f2084f
Cr-Commit-Position: refs/heads/master@{#292793}