Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: src/opts/SkBlurImage_opts_arm.cpp

Issue 520963002: Disable NEON procs for box blur as it produces invalid results (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « expectations/gm/ignored-tests.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 ARM Ltd. 2 * Copyright 2014 ARM Ltd.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBlurImage_opts_neon.h" 8 #include "SkBlurImage_opts_neon.h"
9 #include "SkUtilsArm.h" 9 #include "SkUtilsArm.h"
10 10
11 bool SkBoxBlurGetPlatformProcs(SkBoxBlurProc* boxBlurX, 11 bool SkBoxBlurGetPlatformProcs(SkBoxBlurProc* boxBlurX,
12 SkBoxBlurProc* boxBlurY, 12 SkBoxBlurProc* boxBlurY,
13 SkBoxBlurProc* boxBlurXY, 13 SkBoxBlurProc* boxBlurXY,
14 SkBoxBlurProc* boxBlurYX) { 14 SkBoxBlurProc* boxBlurYX) {
15 // Temporary workaround for http://skbug.com/2845
16 return false;
17
15 #if SK_ARM_NEON_IS_NONE 18 #if SK_ARM_NEON_IS_NONE
16 return false; 19 return false;
17 #elif defined(SK_CPU_ARM64) // Temporary fix for
18 return false; // http://skbug.com/2845
19 #else 20 #else
20 #if SK_ARM_NEON_IS_DYNAMIC 21 #if SK_ARM_NEON_IS_DYNAMIC
21 if (!sk_cpu_arm_has_neon()) { 22 if (!sk_cpu_arm_has_neon()) {
22 return false; 23 return false;
23 } 24 }
24 #endif 25 #endif
25 return SkBoxBlurGetPlatformProcs_NEON(boxBlurX, boxBlurY, boxBlurXY, boxBlur YX); 26 return SkBoxBlurGetPlatformProcs_NEON(boxBlurX, boxBlurY, boxBlurXY, boxBlur YX);
26 #endif 27 #endif
27 } 28 }
OLDNEW
« no previous file with comments | « expectations/gm/ignored-tests.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698