Issue 520963002: Disable NEON procs for box blur as it produces invalid results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 520963002: Disable NEON procs for box blur as it produces invalid results (Closed)

Created:
6 years, 3 months ago by djsollen

Modified:
6 years, 3 months ago

Reviewers:
mtklein, senorblanco

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Disable NEON procs for box blur as it produces invalid results BUG=skia:2845 Committed: https://skia.googlesource.com/skia/+/4a1764688c990fb926aaeab538497dad52768d99

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	expectations/gm/ignored-tests.txt	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/opts/SkBlurImage_opts_arm.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/520963002/1

6 years, 3 months ago (2014-09-02 12:25:03 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 4a1764688c990fb926aaeab538497dad52768d99

6 years, 3 months ago (2014-09-02 12:32:29 UTC) #6

djsollen

6 years, 3 months ago (2014-09-02 13:31:34 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/531023002/ by djsollen@google.com.

The reason for reverting is: failing more GMs than expected..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages