[MediaGalleries] iPhoto: Add original file field to the parser. Dedupe album names.

chrome/utility/media_galleries/iphoto_library_parser_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "chrome/common/media_galleries/iphoto_library.h"
 #include "chrome/utility/media_galleries/iphoto_library_parser.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #define SIMPLE_HEADER()                          \
@@ skipping 24 matching lines @@
     "    </dict>"
 
 #define IMAGE_LIST_HEADER()           \
     "   <key>Master Image List</key>" \
     "   <dict>"
 
 #define IMAGE_LIST_FOOTER() \
     "   </dict>"
 
 #define SIMPLE_PHOTO(id, guid, path, caption) \
-    "  <key>" #id "</key>"             \
-    "  <dict>"                         \
-    "    <key>MediaType</key>"         \
-    "    <string>Image</string>"       \
-    "    <key>Caption</key>"           \
-    "    <string>" caption "</string>" \
-    "    <key>GUID</key>"              \
-    "    <string>" #guid "</string>"   \
-    "    <key>ImagePath</key>"         \
-    "    <string>" path "</string>"    \
-    "    <key>ThumbPath</key>"         \
-    "    <string>" path "</string>"    \
+    "  <key>" #id "</key>"                    \
+    "  <dict>"                                \
+    "    <key>MediaType</key>"                \
+    "    <string>Image</string>"              \
+    "    <key>Caption</key>"                  \
+    "    <string>" caption "</string>"        \
+    "    <key>GUID</key>"                     \
+    "    <string>" #guid "</string>"          \
+    "    <key>ModDateAsTimerInterval</key>"   \
+    "    <string>386221543.0000</string>"     \
+    "    <key>DateAsTimerInterval</key>"      \
+    "    <string>386221543.0000</string>"     \
+    "    <key>DateAsTimerIntervalGMT</key>"   \
+    "    <string>385123456.00</string>"       \
+    "    <key>ImagePath</key>"                \
+    "    <string>" path "</string>"           \
+    "    <key>OriginalPath</key>"             \
+    "    <string>/original" path "</string>"  \
+    "    <key>ThumbPath</key>"                \
+    "    <string>" path "</string>"           \
     "  </dict>"
 
 #define SIMPLE_FOOTER()  \
     "  </dict>"          \
     "</plist>"
 
  // Mismatched key/string tag at ImagePath.
 #define MALFORMED_PHOTO1(id, guid, path, caption) \
     "  <key>" #id "</key>"             \
     "  <dict>"                         \
@@ skipping 25 matching lines @@
     "    <string>" path "</string>"    \
     "  </dict>"
 
 namespace iphoto {
 
 namespace {
 
 void ComparePhoto(const parser::Photo& a, const parser::Photo& b) {
   EXPECT_EQ(a.id, b.id);
   EXPECT_EQ(a.location.value(), b.location.value());
+  EXPECT_EQ(a.original_location.value(), b.original_location.value());
 }
 
 void CompareAlbum(const parser::Album& a, const parser::Album& b) {
   EXPECT_EQ(a.size(), b.size());
 
   parser::Album::const_iterator a_it;
   parser::Album::const_iterator b_it;
   for (a_it = a.begin(), b_it = b.begin();
        a_it != a.end() && b_it != b.end();
        ++a_it, ++b_it) {
@@ skipping 33 matching lines @@
   void TestParser(bool expected_result, const std::string& xml) {
     IPhotoLibraryParser parser;
 
     EXPECT_EQ(expected_result, parser.Parse(xml));
     if (!expected_result)
       return;
 
     CompareLibrary(expected_library_, parser.library());
   }
 
-  void AddExpectedPhoto(uint32 id, const std::string& location,
+  void AddExpectedPhoto(uint32 id,
+                        const std::string& location,
                         const std::string& album) {
-    parser::Photo photo(id, base::FilePath::FromUTF8Unsafe(location));
+    parser::Photo photo(id, base::FilePath::FromUTF8Unsafe(location),
+                        base::FilePath::FromUTF8Unsafe("/original" + location));
     if (!album.empty())
       expected_library_.albums[album].insert(id);
     expected_library_.all_photos.insert(photo);
   }
 
  private:
   parser::Library expected_library_;
 
   DISALLOW_COPY_AND_ASSIGN(IPhotoLibraryParserTest);
 };
@@ skipping 112 matching lines @@
       false,
       SIMPLE_HEADER()
       ALBUMS_HEADER()
       ALBUMS_FOOTER()
       IMAGE_LIST_HEADER()
       MALFORMED_PHOTO2(1, 1, "/bad.jpg", "p1")
       IMAGE_LIST_FOOTER()
       SIMPLE_FOOTER());
 }
 
+TEST_F(IPhotoLibraryParserTest, DuplicateAlbumNames) {
+  AddExpectedPhoto(1, "/dir/PhotoA1.jpg", "Album 1");
+  AddExpectedPhoto(2, "/dir/PhotoA2.jpg", "Album 1");
+  AddExpectedPhoto(3, "/dir/PhotoA3.jpg", "Album 1(11)");
+  AddExpectedPhoto(4, "/dir/PhotoB1.jpg", "Album 1(11)");
+  TestParser(
+      true,
+      SIMPLE_HEADER()
+      ALBUMS_HEADER()
+      SIMPLE_ALBUM(10, "Album 1", 1, 2)
+      SIMPLE_ALBUM(11, "Album 1", 3, 4)
+      ALBUMS_FOOTER()
+      IMAGE_LIST_HEADER()
+      SIMPLE_PHOTO(1, 1, "/dir/PhotoA1.jpg", "Photo 1")
+      SIMPLE_PHOTO(2, 2, "/dir/PhotoA2.jpg", "Photo 2")
+      SIMPLE_PHOTO(3, 3, "/dir/PhotoA3.jpg", "Photo 3")
+      SIMPLE_PHOTO(4, 4, "/dir/PhotoB1.jpg", "Photo 4")
+      IMAGE_LIST_FOOTER()
+      SIMPLE_FOOTER());
+}
+
 }  // namespace
 
 }  // namespace iphoto