webkit/browser/storage_browser_export.h - Issue 520913003: Split storage macros into storage and storage_common

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/browser/storage_browser_export.h

Issue 520913003: Split storage macros into storage and storage_common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move storage_export.h back to browser/ and rename storage_browser_export.h Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/browser/storage_browser_export.h

diff --git a/webkit/common/storage_export.h b/webkit/browser/storage_browser_export.h

similarity index 75%

rename from webkit/common/storage_export.h

rename to webkit/browser/storage_browser_export.h

index 3d85ab4f6a236bdb9936d57849b0f33ef2f07698..aeb2a391818df069e170924d45b7ac5058d53bde 100644

--- a/webkit/common/storage_export.h

+++ b/webkit/browser/storage_browser_export.h

@@ -2,22 +2,22 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef WEBKIT_COMMON_STORAGE_EXPORT_H_

-#define WEBKIT_COMMON_STORAGE_EXPORT_H_

+#ifndef WEBKIT_STORAGE_EXPORT_H_

jamesr 2014/08/29 21:28:46 please fix the guard. should be WEBKIT_BROWSER_ST

+#define WEBKIT_STORAGE_EXPORT_H_

#if defined(COMPONENT_BUILD)

#if defined(WIN32)

-#if defined(STORAGE_IMPLEMENTATION)

+#if defined(STORAGE_BROWSER_IMPLEMENTATION)

#define STORAGE_EXPORT __declspec(dllexport)

#define STORAGE_EXPORT_PRIVATE __declspec(dllexport)

#else

#define STORAGE_EXPORT __declspec(dllimport)

#define STORAGE_EXPORT_PRIVATE __declspec(dllimport)

-#endif // defined(STORAGE_IMPLEMENTATION)

+#endif // defined(STORAGE_BROWSER_IMPLEMENTATION)

#else // defined(WIN32)

-#if defined(STORAGE_IMPLEMENTATION)

+#if defined(STORAGE_BROWSER_IMPLEMENTATION)

#define STORAGE_EXPORT __attribute__((visibility("default")))

#define STORAGE_EXPORT_PRIVATE __attribute__((visibility("default")))

#else

@@ -31,4 +31,4 @@

#define STORAGE_EXPORT_PRIVATE

#endif

-#endif // WEBKIT_COMMON_STORAGE_EXPORT_H_

+#endif // WEBKIT_STORAGE_EXPORT_H_

« no previous file with comments | « webkit/browser/quota/usage_tracker.h ('k') | webkit/common/BUILD.gn » ('j') | no next file with comments »