Split storage macros into storage and storage_common

Split storage macros into storage and storage_common

BUG=338338
TBR=darin@chromium.org

Committed: https://crrev.com/0e4d1cb38348912af0eac189fbb71029adaa7fc0
Cr-Commit-Position: refs/heads/master@{#292743}

[pilgrim_google, 2014-08-29 20:43:40]

pilgrim@chromium.org changed reviewers:
+ darin@chromium.org, jam@chromium.org, jamesr@chromium.org

[jamesr, 2014-08-29 20:46:10]

https://codereview.chromium.org/520913003/diff/1/webkit/browser/BUILD.gn
File webkit/browser/BUILD.gn (right):

https://codereview.chromium.org/520913003/diff/1/webkit/browser/BUILD.gn#newc...
webkit/browser/BUILD.gn:8: "../common/storage_export.h",
this should be using its own export header

https://codereview.chromium.org/520913003/diff/1/webkit/browser/BUILD.gn#newc...
webkit/browser/BUILD.gn:155: defines = [ "STORAGE_IMPLEMENTATION" ]
this should be something like STORAGE_BROWSER_IMPLEMENTATION

https://codereview.chromium.org/520913003/diff/1/webkit/common/storage_export.h
File webkit/common/storage_export.h (right):

https://codereview.chromium.org/520913003/diff/1/webkit/common/storage_export...
webkit/common/storage_export.h:5: #ifndef WEBKIT_STORAGE_EXPORT_H_
what's this file used for now?

[pilgrim_google, 2014-08-29 20:50:18]

On 2014/08/29 20:46:10, jamesr wrote:
> https://codereview.chromium.org/520913003/diff/1/webkit/browser/BUILD.gn
> File webkit/browser/BUILD.gn (right):
> 
>
https://codereview.chromium.org/520913003/diff/1/webkit/browser/BUILD.gn#newc...
> webkit/browser/BUILD.gn:8: "../common/storage_export.h",
> this should be using its own export header

It is. (It's in common/ instead of browser/. I can change that if you like, but
it's using its own export header.)

> 
>
https://codereview.chromium.org/520913003/diff/1/webkit/browser/BUILD.gn#newc...
> webkit/browser/BUILD.gn:155: defines = [ "STORAGE_IMPLEMENTATION" ]
> this should be something like STORAGE_BROWSER_IMPLEMENTATION

OK.

> 
>
https://codereview.chromium.org/520913003/diff/1/webkit/common/storage_export.h
> File webkit/common/storage_export.h (right):
> 
>
https://codereview.chromium.org/520913003/diff/1/webkit/common/storage_export...
> webkit/common/storage_export.h:5: #ifndef WEBKIT_STORAGE_EXPORT_H_
> what's this file used for now?

Everything that used to use browser/storage_export.h

[jamesr, 2014-08-29 20:53:39]

On 2014/08/29 20:50:18, pilgrim_google wrote:
> On 2014/08/29 20:46:10, jamesr wrote:
> > https://codereview.chromium.org/520913003/diff/1/webkit/browser/BUILD.gn
> > File webkit/browser/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/520913003/diff/1/webkit/browser/BUILD.gn#newc...
> > webkit/browser/BUILD.gn:8: "../common/storage_export.h",
> > this should be using its own export header
> 
> It is. (It's in common/ instead of browser/. I can change that if you like,
but
> it's using its own export header.)

Please put the export header for the component with the rest of the files.  Call
it storage_browser_export.h if it's the export header for the storage_browser
component.

[pilgrim_google, 2014-08-29 21:18:23]

On 2014/08/29 20:53:39, jamesr wrote:
> Please put the export header for the component with the rest of the files. 
Call
> it storage_browser_export.h if it's the export header for the storage_browser
> component.

Done.

[jamesr, 2014-08-29 21:28:46]

lgtm

https://codereview.chromium.org/520913003/diff/20001/webkit/browser/storage_b...
File webkit/browser/storage_browser_export.h (right):

https://codereview.chromium.org/520913003/diff/20001/webkit/browser/storage_b...
webkit/browser/storage_browser_export.h:5: #ifndef WEBKIT_STORAGE_EXPORT_H_
please fix the guard. should be

WEBKIT_BROWSER_STORAGE_BROWSER_EXPORT_H_

[pilgrim_google, 2014-08-29 22:35:12]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2014-08-29 22:37:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pilgrim@chromium.org/520913003/40001

[commit-bot: I haz the power, 2014-08-29 23:40:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-30 01:17:15]

Committed patchset #3 (id:40001) as 77c4bb4c32379133027355e20ff2b0e9d996069d

[commit-bot: I haz the power, 2014-09-10 03:12:39]

Patchset 3 (id:??) landed as
https://crrev.com/0e4d1cb38348912af0eac189fbb71029adaa7fc0
Cr-Commit-Position: refs/heads/master@{#292743}