Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5209004: Loosen the checks for numbers in layout test controller. (Closed)

Created:
10 years, 1 month ago by tony
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Loosen the checks for numbers in layout test controller. To fix https://bugs.webkit.org/show_bug.cgi?id=49036, I'm planning on removing the int32 value and just using a number. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M webkit/tools/test_shell/layout_test_controller.cc View 5 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
10 years, 1 month ago (2010-11-18 20:10:56 UTC) #1
tony
The mac and linux results are not to be trusted (they're running the wrong version ...
10 years, 1 month ago (2010-11-18 20:11:58 UTC) #2
jam
10 years, 1 month ago (2010-11-18 21:22:38 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698