Issue 520863005: Revert of Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 520863005: Revert of Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes. (Closed)

Created:
6 years, 3 months ago by ckocagil

Modified:
6 years, 3 months ago

Reviewers:
robertshield, grt (UTC plus 2)

CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@regtest

Project:
chromium

Visibility:
Public.

Revert of Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes. (patchset #4 id:80001 of https://codereview.chromium.org/521703002/) Reason for revert: Breaks InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 Original issue's description: > Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes. > > Use registry virtualization so that stale data on the test machines > don't interfere with the tests. > > BUG=375739 > > Committed: https://chromium.googlesource.com/chromium/src/+/6d6ac988d6a7a311876f3b0d0257086ac58c8181 TBR=robertshield@chromium.org,grt@chromium.org NOTREECHECKS=true NOTRY=true BUG=375739 Committed: https://crrev.com/431601062f90a81d0db9db68dc033904793cf988 Cr-Commit-Position: refs/heads/master@{#292812}

Created: 6 years, 3 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -19 lines)			Patch
	M	chrome/installer/util/installer_state_unittest.cc	View		2 chunks	+0 lines, -14 lines	0 comments	Download
	M	chrome/installer/util/product_unittest.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

ckocagil

Created Revert of Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes.

6 years, 3 months ago (2014-08-31 04:27:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/520863005/1

6 years, 3 months ago (2014-08-31 04:28:54 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 418f357e9eb1f07d0d47e670c5a75be04ce907b8

6 years, 3 months ago (2014-08-31 04:30:48 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:14:58 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/431601062f90a81d0db9db68dc033904793cf988
Cr-Commit-Position: refs/heads/master@{#292812}