chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc - Issue 520743002: The password bubble should fade out on click on the web page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

Issue 520743002: The password bubble should fade out on click on the web page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('K') | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

index 0a1a9ffeb1d4ea6c3a791a0e290efe3bb84f0c28..02ca663950ea669c6cd54e86243e194da2094175 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

@@ -52,7 +52,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, BasicOpenAndClose) {

EXPECT_TRUE(bubble->initially_focused_view());

EXPECT_EQ(bubble->initially_focused_view(),

bubble->GetFocusManager()->GetFocusedView());

- EXPECT_FALSE(bubble->IsTimerRunning());

+ EXPECT_FALSE(bubble->IsFadingAway());

ManagePasswordsBubbleView::CloseBubble();

EXPECT_FALSE(ManagePasswordsBubbleView::IsShowing());

@@ -80,6 +80,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, CommandControlsBubble) {

EXPECT_TRUE(bubble->initially_focused_view());

EXPECT_EQ(bubble->initially_focused_view(),

bubble->GetFocusManager()->GetFocusedView());

+ EXPECT_FALSE(bubble->IsFadingAway());

ManagePasswordsBubbleView::CloseBubble();

EXPECT_FALSE(ManagePasswordsBubbleView::IsShowing());

@@ -120,8 +121,8 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest,

// Bubble can be active if user clicks it.

EXPECT_TRUE(ManagePasswordsBubbleView::manage_password_bubble()->

CanActivate());

- EXPECT_TRUE(ManagePasswordsBubbleView::manage_password_bubble()->

- IsTimerRunning());

+ EXPECT_FALSE(ManagePasswordsBubbleView::manage_password_bubble()->

+ IsFadingAway());

scoped_ptr<base::HistogramSamples> samples(

GetSamples(kDisplayDispositionMetric));

@@ -188,5 +189,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, CloseOnClick) {

EXPECT_FALSE(ManagePasswordsBubbleView::manage_password_bubble()->

GetFocusManager()->GetFocusedView());

ui_test_utils::ClickOnView(browser(), VIEW_ID_TAB_CONTAINER);

- EXPECT_FALSE(ManagePasswordsBubbleView::IsShowing());

+ EXPECT_TRUE(ManagePasswordsBubbleView::manage_password_bubble()->

+ IsFadingAway());

+ EXPECT_TRUE(ManagePasswordsBubbleView::IsShowing());

}