Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 520633005: Reduce flakes in the mini_installer test. (Closed)

Created:
6 years, 3 months ago by grt (UTC plus 2)
Modified:
6 years, 3 months ago
Reviewers:
robertshield
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@notreached
Project:
chromium
Visibility:
Public.

Description

Reduce flakes in the mini_installer test. This change makes the test more resilient to unexpected state on the machine. - RegistryVerifier can now verify that registry values are not present (and, as a result, optional registry keys). A key's "exists" property can be one of "required", "forbidden", or "optional". The first two behave identically to the true and false boolean values of the previous implementation. For an "optional" key, values within it may have an empty dict (i.e., with no "type" or "data" members) to indicate that the value must not be present in the key if the key is present. - Each test now begins with the "no_pv" state rather than the "clean" state. This is more permissive, and simply ensures that Chrome is not registered with Google Update. - After attempting to force-uninstall Chrome (either before executing a test or after a test failure), the harness will unconditionally delete the Google Update registration of that Chrome if it is present. This will clean the machine sufficiently for a subsequent test run. BUG=375739, 401148, 402081 R=robertshield@chromium.org NOTRY=true Committed: https://crrev.com/92a819b0b7898057df793b90d66ca0d31c4d9063 Cr-Commit-Position: refs/heads/master@{#292943}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -32 lines) Patch
M chrome/test/mini_installer/config/chrome_system_installed.prop View 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/test/mini_installer/config/chrome_system_no_pv.prop View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/mini_installer/config/chrome_system_not_installed.prop View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/mini_installer/config/chrome_user_installed.prop View 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/test/mini_installer/config/chrome_user_no_pv.prop View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/mini_installer/config/chrome_user_not_installed.prop View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/mini_installer/config/config.config View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/mini_installer/registry_verifier.py View 1 3 chunks +20 lines, -9 lines 0 comments Download
M chrome/test/mini_installer/test_installer.py View 3 chunks +30 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
grt (UTC plus 2)
6 years, 3 months ago (2014-09-02 15:15:39 UTC) #1
robertshield
lgtm https://codereview.chromium.org/520633005/diff/20001/chrome/test/mini_installer/registry_verifier.py File chrome/test/mini_installer/registry_verifier.py (right): https://codereview.chromium.org/520633005/diff/20001/chrome/test/mini_installer/registry_verifier.py#newcode75 chrome/test/mini_installer/registry_verifier.py:75: # Values are not checked if the missing ...
6 years, 3 months ago (2014-09-02 15:45:27 UTC) #2
grt (UTC plus 2)
Thanks! https://codereview.chromium.org/520633005/diff/20001/chrome/test/mini_installer/registry_verifier.py File chrome/test/mini_installer/registry_verifier.py (right): https://codereview.chromium.org/520633005/diff/20001/chrome/test/mini_installer/registry_verifier.py#newcode75 chrome/test/mini_installer/registry_verifier.py:75: # Values are not checked if the missing ...
6 years, 3 months ago (2014-09-02 16:37:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/520633005/40001
6 years, 3 months ago (2014-09-02 16:38:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 6bd93bb9b248a64398f1a5d10758ea12fd96b9df
6 years, 3 months ago (2014-09-02 16:39:47 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:19:00 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92a819b0b7898057df793b90d66ca0d31c4d9063
Cr-Commit-Position: refs/heads/master@{#292943}

Powered by Google App Engine
This is Rietveld 408576698