Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 520623002: Remove Files.app's own profile badge. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 3 months ago
Reviewers:
yoshiki, benwells, hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Files.app's own profile badge. Now that the Files.app uses default system header, the own profile badge is redundant. BUG=408816 TEST=confirmed manually, ran browser_tests Committed: https://crrev.com/14cea1d24143dac7c558779ffbef6e735e55d819 Cr-Commit-Position: refs/heads/master@{#292827}

Patch Set 1 #

Patch Set 2 : Remove profileImage from private api. #

Total comments: 2

Patch Set 3 : Remove unused content from parameter list. #

Patch Set 4 : Rebase. #

Messages

Total messages: 25 (1 generated)
fukino
fukino@chromium.org changed reviewers: + hirono@chromium.org
6 years, 3 months ago (2014-08-29 10:06:33 UTC) #1
fukino
hirono@ - PTAL the CL? Thanks!
6 years, 3 months ago (2014-08-29 10:08:10 UTC) #2
hirono
On 2014/08/29 10:08:10, fukino wrote: > hirono@ - PTAL the CL? Thanks! Could you remove ...
6 years, 3 months ago (2014-08-29 10:18:34 UTC) #3
fukino
Edited following files to remove profileImage from the API. - chrome/common/extensions/api/file_browser_private.idl - chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
6 years, 3 months ago (2014-08-29 10:37:54 UTC) #4
hirono
https://codereview.chromium.org/520623002/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc File chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc (right): https://codereview.chromium.org/520623002/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc#newcode65 chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc:65: GetLoggedInProfileInfoList(content::WebContents* contents) { We can remove contents also.
6 years, 3 months ago (2014-08-29 11:13:26 UTC) #5
fukino
Thank you for catching! https://codereview.chromium.org/520623002/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc File chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc (right): https://codereview.chromium.org/520623002/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc#newcode65 chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc:65: GetLoggedInProfileInfoList(content::WebContents* contents) { On 2014/08/29 ...
6 years, 3 months ago (2014-08-29 11:22:09 UTC) #6
hirono
On 2014/08/29 11:22:09, fukino wrote: > Thank you for catching! > > https://codereview.chromium.org/520623002/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc > File ...
6 years, 3 months ago (2014-08-29 11:31:10 UTC) #7
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 3 months ago (2014-08-29 12:16:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/520623002/40001
6 years, 3 months ago (2014-08-29 12:16:56 UTC) #9
fukino
The CQ bit was unchecked by fukino@chromium.org
6 years, 3 months ago (2014-08-29 12:22:40 UTC) #10
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 3 months ago (2014-08-29 12:25:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/520623002/60001
6 years, 3 months ago (2014-08-29 12:25:58 UTC) #12
fukino
The CQ bit was unchecked by fukino@chromium.org
6 years, 3 months ago (2014-08-29 12:43:24 UTC) #13
fukino
fukino@chromium.org changed reviewers: + yoshiki@chromium.org
6 years, 3 months ago (2014-08-29 12:46:56 UTC) #14
fukino
yoshiki@, could you take a look at chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc? Thanks!
6 years, 3 months ago (2014-08-29 12:47:26 UTC) #15
fukino
fukino@chromium.org changed reviewers: + benwells@chromium.org
6 years, 3 months ago (2014-08-29 14:23:03 UTC) #16
fukino
Hi benwells@, could you take a look at chrome/common/extensions/api/file_browser_private.idl? Thanks!
6 years, 3 months ago (2014-08-29 14:23:37 UTC) #17
benwells
lgtm
6 years, 3 months ago (2014-09-01 01:35:11 UTC) #18
benwells
idl and c/b/chromeos/e/file_manager/private_api_misc.cc lgtm
6 years, 3 months ago (2014-09-01 01:37:32 UTC) #19
yoshiki
lgtm
6 years, 3 months ago (2014-09-01 02:41:35 UTC) #20
fukino
On 2014/09/01 02:41:35, yoshiki wrote: > lgtm Thanks!
6 years, 3 months ago (2014-09-01 03:22:28 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/520623002/60001
6 years, 3 months ago (2014-09-01 03:23:04 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 7a7a13ebb95c47517017d751dd80cbde9602b366
6 years, 3 months ago (2014-09-01 03:28:59 UTC) #24
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:15:24 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/14cea1d24143dac7c558779ffbef6e735e55d819
Cr-Commit-Position: refs/heads/master@{#292827}

Powered by Google App Engine
This is Rietveld 408576698