Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 520613004: Remove network_prediction_enabled from profile_io_data. (Closed)

Created:
6 years, 3 months ago by Bence
Modified:
6 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove network_prediction_enabled from profile_io_data. Cleanup: This member has been obsoleted by https://crrev.com/516443002. BUG=334602 Committed: https://crrev.com/83eeb4359d472fea8f7b295c956c4ca08aa6ceaa Cr-Commit-Position: refs/heads/master@{#292980}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/browser/profiles/profile_io_data.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +0 lines, -7 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
Bence
PTAL.
6 years, 3 months ago (2014-08-29 21:00:21 UTC) #2
mmenke
https://codereview.chromium.org/520613004/diff/1/chrome/browser/profiles/profile_io_data.cc File chrome/browser/profiles/profile_io_data.cc (left): https://codereview.chromium.org/520613004/diff/1/chrome/browser/profiles/profile_io_data.cc#oldcode469 chrome/browser/profiles/profile_io_data.cc:469: network_prediction_enabled_.Init(prefs::kNetworkPredictionEnabled, Shouldn't you remove kNetworkPredictionEnabled as well?
6 years, 3 months ago (2014-09-02 15:09:29 UTC) #3
Bence
https://codereview.chromium.org/520613004/diff/1/chrome/browser/profiles/profile_io_data.cc File chrome/browser/profiles/profile_io_data.cc (left): https://codereview.chromium.org/520613004/diff/1/chrome/browser/profiles/profile_io_data.cc#oldcode469 chrome/browser/profiles/profile_io_data.cc:469: network_prediction_enabled_.Init(prefs::kNetworkPredictionEnabled, On 2014/09/02 15:09:29, mmenke wrote: > Shouldn't you ...
6 years, 3 months ago (2014-09-02 18:09:17 UTC) #4
mmenke
On 2014/09/02 18:09:17, Bence wrote: > https://codereview.chromium.org/520613004/diff/1/chrome/browser/profiles/profile_io_data.cc > File chrome/browser/profiles/profile_io_data.cc (left): > > https://codereview.chromium.org/520613004/diff/1/chrome/browser/profiles/profile_io_data.cc#oldcode469 > ...
6 years, 3 months ago (2014-09-02 18:11:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/520613004/1
6 years, 3 months ago (2014-09-02 18:16:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1c37bd30041af9926fde9fdef601b67f5d04be33
6 years, 3 months ago (2014-09-02 19:54:48 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83eeb4359d472fea8f7b295c956c4ca08aa6ceaa
Cr-Commit-Position: refs/heads/master@{#292980}

Powered by Google App Engine
This is Rietveld 408576698