media/audio/pulse/pulse_input.cc - Issue 520613003: Fix memory leaks related to PulseAudioInputStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/pulse/pulse_input.cc

Issue 520613003: Fix memory leaks related to PulseAudioInputStream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comment. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/pulse/pulse_input.cc

diff --git a/media/audio/pulse/pulse_input.cc b/media/audio/pulse/pulse_input.cc

index 6c9855e504c568bf47771ae04e6470c5f06ac061..0a9e909a59293854a13cfa1f42071d6e7be3c879 100644

--- a/media/audio/pulse/pulse_input.cc

+++ b/media/audio/pulse/pulse_input.cc

@@ -119,7 +119,10 @@ void PulseAudioInputStream::Close() {

if (handle_) {

// Disable all the callbacks before disconnecting.

pa_stream_set_state_callback(handle_, NULL, NULL);

- pa_stream_flush(handle_, NULL, NULL);

+ pa_operation* operation = pa_stream_flush(handle_,

DaleCurtis 2014/08/29 18:12:04 Wrapping is incorrect, move handle_ to the next li

+ &pulse::StreamSuccessCallback,

+ pa_mainloop_);

+ WaitForOperationCompletion(pa_mainloop_, operation);

if (pa_stream_get_state(handle_) != PA_STREAM_UNCONNECTED)

pa_stream_disconnect(handle_);

« no previous file with comments | « no previous file | no next file » | no next file with comments »