Fix memory leaks related to PulseAudioInputStream.

Fix memory leaks related to PulseAudioInputStream.

pa_stream_flush() returns a pa_operation object on success, so we must unref it by calling pa_operation_unref() to avoid memory leaks.

BUG=238493
Committed: https://crrev.com/a717f8a43530887262222c6796dd9baf4e885c6b
Cr-Commit-Position: refs/heads/master@{#292705}

[babu, 2014-08-29 16:48:00]

sudarsana.nagineni@intel.com changed reviewers:
+ xians@chromium.org

[DaleCurtis, 2014-08-29 17:07:47]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2014-08-29 17:07:48]

https://codereview.chromium.org/520613003/diff/1/media/audio/pulse/pulse_inpu...
File media/audio/pulse/pulse_input.cc (right):

https://codereview.chromium.org/520613003/diff/1/media/audio/pulse/pulse_inpu...
media/audio/pulse/pulse_input.cc:122: pa_operation* operation =
pa_stream_flush(handle_, NULL, NULL);
Just use WaitForOperationCompletion here.

[babu, 2014-08-29 18:06:37]

@dalecurtis, thanks for reviewing.

On 2014/08/29 17:07:48, DaleCurtis wrote:

>
https://codereview.chromium.org/520613003/diff/1/media/audio/pulse/pulse_inpu...
> media/audio/pulse/pulse_input.cc:122: pa_operation* operation =
> pa_stream_flush(handle_, NULL, NULL);
> Just use WaitForOperationCompletion here.

fixed.

[DaleCurtis, 2014-08-29 18:12:04]

lgtm % nit.

https://codereview.chromium.org/520613003/diff/20001/media/audio/pulse/pulse_...
File media/audio/pulse/pulse_input.cc (right):

https://codereview.chromium.org/520613003/diff/20001/media/audio/pulse/pulse_...
media/audio/pulse/pulse_input.cc:122: pa_operation* operation =
pa_stream_flush(handle_,
Wrapping is incorrect, move handle_ to the next line too.

[babu, 2014-08-29 18:21:08]

>
https://codereview.chromium.org/520613003/diff/20001/media/audio/pulse/pulse_...
> media/audio/pulse/pulse_input.cc:122: pa_operation* operation =
> pa_stream_flush(handle_,
> Wrapping is incorrect, move handle_ to the next line too.

Done.

[babu, 2014-08-29 19:22:54]

The CQ bit was checked by sudarsana.nagineni@intel.com

[commit-bot: I haz the power, 2014-08-29 19:24:13]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/sudarsana.nagineni@intel.com/520613003...

[commit-bot: I haz the power, 2014-08-29 22:58:46]

Committed patchset #3 (id:40001) as 1a7eca12a10e652b5beb1534d69c48697e1709ad

[no longer working on chromium, 2014-09-01 07:59:43]

lgtm, thanks for fixing it.

[commit-bot: I haz the power, 2014-09-10 03:11:20]

Patchset 3 (id:??) landed as
https://crrev.com/a717f8a43530887262222c6796dd9baf4e885c6b
Cr-Commit-Position: refs/heads/master@{#292705}