Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 520593006: Lower media::RendererImpl DVLOG level by 1. (Closed)

Created:
6 years, 3 months ago by scherkus (not reviewing)
Modified:
6 years, 3 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Lower media::RendererImpl DVLOG level by 1. Most of these events are infrequent yet very useful when debugging. Committed: https://crrev.com/792fb3d7effa92566bdac59bff0f50a2f6f418f3 Cr-Commit-Position: refs/heads/master@{#292765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M media/filters/renderer_impl.cc View 20 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
scherkus (not reviewing)
I find --v=2 to produce too much spam.
6 years, 3 months ago (2014-08-29 23:43:39 UTC) #2
xhwang
lgtm This is what I use: 1: error/unusual cases 2: important events like init/flush/end 3: ...
6 years, 3 months ago (2014-08-29 23:47:17 UTC) #3
scherkus (not reviewing)
On 2014/08/29 23:47:17, xhwang wrote: > lgtm > > This is what I use: > ...
6 years, 3 months ago (2014-08-29 23:50:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/520593006/1
6 years, 3 months ago (2014-08-29 23:54:39 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-30 01:30:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0afab38c696dc08ab8ded394f6a462f45e6869d1
6 years, 3 months ago (2014-08-30 02:32:22 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:13:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/792fb3d7effa92566bdac59bff0f50a2f6f418f3
Cr-Commit-Position: refs/heads/master@{#292765}

Powered by Google App Engine
This is Rietveld 408576698