Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 520503004: Merge base unit tests into src to be in line with Chrome. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev, jochen (gone - plz use gerrit), Michael Starzinger, danno, tfarina
Project:
v8
Visibility:
Public.

Description

Merge base unit tests into src to be in line with Chrome. We still need the test/base-unittests folder until the test driver is updated to handle unittests without the boilerplate. TEST=base-unittests R=svenpanne@chromium.org BUG=v8:3489 LOG=n Committed: https://code.google.com/p/v8/source/detail?r=23516

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1190 lines) Patch
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + src/base/base.gyp View 0 chunks +-1 lines, --1 lines 1 comment Download
A + src/base/bits-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/base/cpu-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/base/flags-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/base/platform/condition-variable-unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
A + src/base/platform/mutex-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/base/platform/platform-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + src/base/platform/semaphore-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/base/platform/time-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/base/sys-info-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/base/utils/random-number-generator-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/base-unittests/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D test/base-unittests/base-unittests.gyp View 1 chunk +0 lines, -45 lines 0 comments Download
D test/base-unittests/bits-unittest.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D test/base-unittests/cpu-unittest.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D test/base-unittests/flags-unittest.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D test/base-unittests/platform/condition-variable-unittest.cc View 1 chunk +0 lines, -301 lines 0 comments Download
D test/base-unittests/platform/mutex-unittest.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D test/base-unittests/platform/platform-unittest.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D test/base-unittests/platform/semaphore-unittest.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D test/base-unittests/platform/time-unittest.cc View 1 chunk +0 lines, -186 lines 0 comments Download
D test/base-unittests/sys-info-unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D test/base-unittests/utils/random-number-generator-unittest.cc View 1 chunk +0 lines, -53 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-08-29 10:44:05 UTC) #1
Benedikt Meurer
Jochen, Michi, Danno: FYI
6 years, 3 months ago (2014-08-29 10:44:54 UTC) #2
Sven Panne
lgtm
6 years, 3 months ago (2014-08-29 10:52:41 UTC) #3
Benedikt Meurer
Committed patchset #1 manually as 23516 (presubmit successful).
6 years, 3 months ago (2014-08-29 10:53:40 UTC) #4
tfarina
6 years, 3 months ago (2014-08-29 15:05:38 UTC) #5
Message was sent while issue was closed.
Thanks for considering doing this way Benedikt!

https://codereview.chromium.org/520503004/diff/1/src/base/base.gyp
File src/base/base.gyp (right):

https://codereview.chromium.org/520503004/diff/1/src/base/base.gyp#newcode1
src/base/base.gyp:1: # Copyright 2014 the V8 project authors. All rights
reserved.
could you name this gyp file base_tests.gyp?

For similar files in Chromium, see cc/cc_tests.gyp, ui/base/ui_base_tests.gyp,
ui/gfx/gfx_tests.gyp among others.

Powered by Google App Engine
This is Rietveld 408576698