Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 520493002: Revert of Fix the Copresence permission. (Closed)

Created:
6 years, 3 months ago by Alpha Left Google
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix the Copresence permission. (patchset #1 of https://codereview.chromium.org/523433002/) Reason for revert: This change causes a test failure: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/48008/steps/unit_tests/logs/stdio Error: [ RUN ] PermissionsTest.PermissionMessages ../../chrome/common/extensions/permissions/permission_set_unittest.cc:781: Failure Value of: permission_info->message_id() Actual: 65 Expected: PermissionMessage::kNone Which is: 1 unexpected message_id for copresence Looks like this change is the cause. Original issue's description: > Fix the Copresence permission. > > The initializer for the Copresence permission is malformed. It specifies the > message id instead of the flag. > > R=kalman@chromium.org > BUG=408843 > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/c2a41e8 TBR=kalman@chromium.org,rkc@chromium.org NOTREECHECKS=true NOTRY=true BUG=408843 Committed: https://crrev.com/7b723d5ca9bcd0b3e7619c08b4284e97ffc25d31 Cr-Commit-Position: refs/heads/master@{#292532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Alpha Left Google
Created Revert of Fix the Copresence permission.
6 years, 3 months ago (2014-08-29 01:10:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/520493002/1
6 years, 3 months ago (2014-08-29 01:11:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as e1a8808d65d8eb1471b6094ea77bb157c3d7c985
6 years, 3 months ago (2014-08-29 01:12:04 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:04:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b723d5ca9bcd0b3e7619c08b4284e97ffc25d31
Cr-Commit-Position: refs/heads/master@{#292532}

Powered by Google App Engine
This is Rietveld 408576698