Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 520303004: Add presubmit check to warn about <label> for usage. (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add presubmit check to warn about <label> for attribute usage. BUG=409938 NOTRY=true Committed: https://crrev.com/422789b69ca80bd858bac30d89e26a5fee47fe33 Cr-Commit-Position: refs/heads/master@{#293601}

Patch Set 1 #

Patch Set 2 : fix check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chrome/browser/PRESUBMIT.py View 1 3 chunks +5 lines, -1 line 0 comments Download
A + chrome/browser/web_dev_style/html_checker.py View 1 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Evan Stade
6 years, 3 months ago (2014-09-03 01:23:54 UTC) #2
Dan Beam
lgtm++
6 years, 3 months ago (2014-09-03 23:48:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/520303004/2
6 years, 3 months ago (2014-09-03 23:51:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8560)
6 years, 3 months ago (2014-09-04 01:33:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/520303004/2
6 years, 3 months ago (2014-09-04 20:06:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8787)
6 years, 3 months ago (2014-09-04 20:22:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/520303004/2
6 years, 3 months ago (2014-09-05 18:11:03 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9054)
6 years, 3 months ago (2014-09-05 18:21:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/520303004/2
6 years, 3 months ago (2014-09-06 01:31:56 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:2) as f699e2abdc779b59a245cc3245b7f877d8747765
6 years, 3 months ago (2014-09-06 01:34:39 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:10 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/422789b69ca80bd858bac30d89e26a5fee47fe33
Cr-Commit-Position: refs/heads/master@{#293601}

Powered by Google App Engine
This is Rietveld 408576698