.

tools/clang/plugins/ChromeClassTester.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A general interface for filtering and only acting on classes in Chromium C++
 // code.
 
 #include "ChromeClassTester.h"
 
 #include <sys/param.h>
 
 #include "clang/AST/AST.h"
+#include "clang/AST/Expr.h"
+#include "clang/AST/RecursiveASTVisitor.h"
 #include "clang/Basic/FileManager.h"
 #include "clang/Basic/SourceManager.h"
 
 using namespace clang;
 
 namespace {
 
+class FunctionVisitor : public RecursiveASTVisitor<FunctionVisitor> {
+ public:
+
+  bool shouldVisitTemplateInstantiations() { return true; }
+
+  bool VisitFunctionDecl(FunctionDecl* fun) {
+    if (fun->doesThisDeclarationHaveABody())
+      funcs_.push_back(fun);
+    return true;
+  }
+
+  std::vector<FunctionDecl*> funcs_;
+};
+
+bool isBasePassedCall(const CallExpr* CE, DeclRefExpr*& DREOut) {
+  const FunctionDecl* D = CE->getDirectCallee();
+  if (!D) return false;
+
+  const NamespaceDecl *ND = dyn_cast<NamespaceDecl>(D->getDeclContext());
+  if (!ND) return false;
+  if (ND->getName() != "base") return false;
+  if (ND->getDeclContext()->getDeclKind() != Decl::TranslationUnit)
+    return false;
+
+  //auto FD = dyn_cast<FunctionDecl>(D);
+  if (!D->getIdentifier()) return false;
+  if (D->getName() != "Passed") return false;
+  if (D->getNumParams() != 1) return false;
+
+  // FIXME: Require this &? Or is without something to catch too?
+  const UnaryOperator* Op =
+      dyn_cast<UnaryOperator>(CE->getArg(0)->IgnoreParenImpCasts());
+  if (!Op || Op->getOpcode() != UO_AddrOf) return false;
+
+  DeclRefExpr* DRE =
+      dyn_cast<DeclRefExpr>(Op->getSubExpr()->IgnoreParenImpCasts());
+  if (!DRE) return false;  // FIXME: or complain? What would this be?
+
+  DREOut = DRE;
+  return true;
+}
+
+typedef std::map<const Decl*, DeclRefExpr*> UseMap;
+
+// |Expr| is a Stmt due to StmtExprs.
+void AddAll(std::vector<const DeclRefExpr*>* out, UseMap* m, Stmt* SExpr) {
+  if (auto CE = dyn_cast<CallExpr>(SExpr)) {
+    // Don't push the DRE from within a base::Passed() CallExpr!
+    DeclRefExpr* DRE;
+    if (isBasePassedCall(CE, DRE)) {
+      (*m)[DRE->getDecl()] = DRE;
+      return;
+    }
+    // FIXME: What if it's a base::Passed() call taking something weird?
+  }
+  else if (auto DRE = dyn_cast<DeclRefExpr>(SExpr))
+    out->push_back(DRE);
+
+  for (Stmt* C : SExpr->children()) {
+    if (!C) continue;
+    AddAll(out, m, C);
+  }
+}
+
+void CheckCall(ChromeClassTester& CCT, CallExpr* S, ASTContext& ctx) {
+  // Recursively collect all expressions in arguments
+  // (this has some false positives, as it stuffs things like "a ? b : c" into
+  // the flat vector even though that has a sequence point).
+  std::vector<const DeclRefExpr*> ArgExprs;
+  UseMap uses;
+  AddAll(&ArgExprs, &uses, S);
+
+  // Find all declrefexprs that are both:
+  // 1.) Passed to base::Passed() (which invalidates them)
+  // 2.) Used in some other way (e.g. have their .get() called)
+
+  for (const DeclRefExpr* E : ArgExprs) {
+    auto it = uses.find(E->getDecl());
+    if (it != uses.end()) {
+      CCT.diagnostic().Report(E->getLocation(),
+                              CCT.diag_might_be_gone_);
+      CCT.diagnostic().Report(it->second->getLocation(),
+                              CCT.diag_might_be_gone_note_here_);
+    }
+  }
+}
+
+void CheckStmts(ChromeClassTester& CCT, Stmt* S, ASTContext& ctx) {
+  for (auto* C : S->children()) {
+    if (!C) continue;
+
+    if (auto* Call = dyn_cast<CallExpr>(C))
+      CheckCall(CCT, Call, ctx);
+    else
+      CheckStmts(CCT, C, ctx);
+  }
+}
+
 bool starts_with(const std::string& one, const std::string& two) {
   return one.compare(0, two.size(), two) == 0;
 }
 
 std::string lstrip(const std::string& one, const std::string& two) {
   if (starts_with(one, two))
     return one.substr(two.size());
   return one;
 }
 
 bool ends_with(const std::string& one, const std::string& two) {
   if (two.size() > one.size())
     return false;
 
   return one.compare(one.size() - two.size(), two.size(), two) == 0;
 }
 
 }  // namespace
 
 ChromeClassTester::ChromeClassTester(CompilerInstance& instance)
     : instance_(instance),
       diagnostic_(instance.getDiagnostics()) {
+
+  diag_might_be_gone_ =
+      diagnostic().getCustomDiagID(DiagnosticsEngine::Warning,
+      "reference might be destroyed here");
+  diag_might_be_gone_note_here_ =
+      diagnostic().getCustomDiagID(DiagnosticsEngine::Note,
+      "invalidated here");
   BuildBannedLists();
 }
 
 ChromeClassTester::~ChromeClassTester() {}
 
 void ChromeClassTester::HandleTagDeclDefinition(TagDecl* tag) {
   pending_class_decls_.push_back(tag);
 }
 
 bool ChromeClassTester::HandleTopLevelDecl(DeclGroupRef group_ref) {
   for (size_t i = 0; i < pending_class_decls_.size(); ++i)
     CheckTag(pending_class_decls_[i]);
   pending_class_decls_.clear();
 
   return true;  // true means continue parsing.
 }
 
+void ChromeClassTester::HandleTranslationUnit(ASTContext& Context) {
+  FunctionVisitor visitor;
+  visitor.TraverseDecl(Context.getTranslationUnitDecl());
+
+  // Now all function decls are in visitor.funcs_.
+  for (auto* Fun : visitor.funcs_) {
+    Stmt* Body = Fun->getBody();
+    assert(Body && "Only definitions should be passed here");
+    CheckStmts(*this, Body, Context);
+  }
+}
+
 void ChromeClassTester::CheckTag(TagDecl* tag) {
   // We handle class types here where we have semantic information. We can only
   // check structs/classes/enums here, but we get a bunch of nice semantic
   // information instead of just parsing information.
 
   if (CXXRecordDecl* record = dyn_cast<CXXRecordDecl>(tag)) {
     // If this is a POD or a class template or a type dependent on a
     // templated class, assume there's no ctor/dtor/virtual method
     // optimization that we can do.
     if (record->isPOD() ||
@@ skipping 239 matching lines @@
   PresumedLoc ploc = source_manager.getPresumedLoc(spelling_location);
   if (ploc.isInvalid()) {
     // If we're in an invalid location, we're looking at things that aren't
     // actually stated in the source.
     return false;
   }
 
   *filename = ploc.getFilename();
   return true;
 }