Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 520283002: .

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
awong
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

plugplugplug BUG=409318

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : close enough #

Patch Set 6 : kinda works #

Patch Set 7 : . #

Total comments: 2

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : ! #

Patch Set 11 : notjustcalls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -2 lines) Patch
M tools/clang/plugins/ChromeClassTester.h View 1 2 3 4 5 3 chunks +6 lines, -2 lines 0 comments Download
M tools/clang/plugins/ChromeClassTester.cpp View 1 2 3 4 5 6 7 8 9 10 4 chunks +152 lines, -0 lines 0 comments Download
A tools/clang/plugins/tests/base_passed.cpp View 1 2 3 4 5 6 7 1 chunk +58 lines, -0 lines 0 comments Download
A tools/clang/plugins/tests/base_passed.txt View 1 2 3 4 5 6 7 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
awong
6 years, 3 months ago (2014-09-04 00:29:51 UTC) #2 
https://codereview.chromium.org/520283002/diff/120001/tools/clang/plugins/tes...
File tools/clang/plugins/tests/base_passed.cpp (right):

https://codereview.chromium.org/520283002/diff/120001/tools/clang/plugins/tes...
tools/clang/plugins/tests/base_passed.cpp:37: }
}  // namespace base

https://codereview.chromium.org/520283002/diff/120001/tools/clang/plugins/tes...
tools/clang/plugins/tests/base_passed.cpp:51: // FIXME: Do I also have to catch
(no &)?
Yes, but your syntax is wrong. base::Passed(s.Pass()).

Powered by Google App Engine
This is Rietveld 408576698