Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 520273002: Make sure primary root window is deleted last. (Closed)

Created:
6 years, 3 months ago by oshima
Modified:
6 years, 3 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Make sure primary root window is deleted last. BUG=403380 R=mukai@chromium.org Committed: https://crrev.com/892f21f9f31a9b7e2bd23430f90c74d1a9dc33f0 Cr-Commit-Position: refs/heads/master@{#292759}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M ash/display/display_controller.cc View 3 chunks +22 lines, -11 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
oshima
https://codereview.chromium.org/520273002/diff/20001/ash/display/display_controller.cc File ash/display/display_controller.cc (left): https://codereview.chromium.org/520273002/diff/20001/ash/display/display_controller.cc#oldcode270 ash/display/display_controller.cc:270: // from the last so that the primary root ...
6 years, 3 months ago (2014-08-30 00:50:36 UTC) #1
Jun Mukai
lgtm
6 years, 3 months ago (2014-08-30 01:01:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/520273002/20001
6 years, 3 months ago (2014-08-30 01:03:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:20001) as cabeae2d354655fce26f8074f521d6c39fb1bdb2
6 years, 3 months ago (2014-08-30 02:11:37 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:13:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/892f21f9f31a9b7e2bd23430f90c74d1a9dc33f0
Cr-Commit-Position: refs/heads/master@{#292759}

Powered by Google App Engine
This is Rietveld 408576698