Make SecurityContext available in RemoteFrames.

Source/web/WebRemoteFrameImpl.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "web/WebRemoteFrameImpl.h"
 
 #include "core/frame/FrameView.h"
 #include "core/frame/RemoteFrame.h"
 #include "core/frame/Settings.h"
@@ skipping 831 matching lines @@
 
 void WebRemoteFrameImpl::initializeFromFrame(WebLocalFrame* source) const
 {
     ASSERT(source);
     WebLocalFrameImpl* localFrameImpl = toWebLocalFrameImpl(source);
     client()->initializeChildFrame(
         localFrameImpl->frame()->view()->frameRect(),
         localFrameImpl->frame()->view()->visibleContentScaleFactor());
 }
 
+void WebRemoteFrameImpl::setReplicatedOrigin(const WebURL& origin, bool isUnique) const

[alexmos, 2014/11/11 23:44:25]

I don't like that this is taking the isUnique flag separately, and this can't
take a FrameReplicationState.  I'm thinking about changing this to take a
WebSecurityOrigin instead, and the work done here to synthesize
WebSecurityOrigin from a FrameReplicationState should happen in some other
helper function in content.  Does that sounds plausible, and if so, where is a
good place to add such a function?

[dcheng, 2014/11/12 21:55:50]

We would probably do the conversion in content. There are a number of different
ways to do this. content::DropData/blink::WebDragData chose to expose a
DropDataBuilder to construct a DropData from WebDragData, and then a static
function in render_view_impl.cc to convert it back to the blink form.

I think it's probably fine to just embed these conversion helpers in
FrameReplicationState directly.

[alexmos, 2014/11/18 18:35:18]

Thanks, I talked to Charlie also and ended up doing the conversion in a static
RenderFrameImpl::SetReplicatedState.

+{
+    ASSERT(frame());
+
+    WebSecurityOrigin securityOrigin;
+    if (isUnique)
+        securityOrigin = WebSecurityOrigin::createUnique();
+    else
+        securityOrigin = WebSecurityOrigin::create(origin);
+    frame()->securityContext()->setReplicatedOrigin(securityOrigin);
+}
+
 } // namespace blink