Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 520123002: Fix matrix similarity test on arm64 (Closed)

Created:
6 years, 3 months ago by jvanverth1
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix matrix similarity test on arm64 Addresses precision issue by using a simpler test. Also fixes issues with IvMatrix::preservesRightAngles, and adds unit tests. BUG=skia:2405 Committed: https://skia.googlesource.com/skia/+/17a845f76094eb3b5ac464556fced2a60dd0f088

Patch Set 1 #

Patch Set 2 : Fix isSimilarity and preservesRightAngles; add unit tests. #

Total comments: 1

Patch Set 3 : Minor clean-ups. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -27 lines) Patch
M include/core/SkMatrix.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkMatrix.cpp View 1 2 3 chunks +10 lines, -16 lines 0 comments Download
M tests/MatrixTest.cpp View 1 3 chunks +39 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jvanverth1
6 years, 3 months ago (2014-09-02 17:20:13 UTC) #2
jvanverth1
6 years, 3 months ago (2014-09-02 17:20:13 UTC) #3
reed1
api (comment) lgtm
6 years, 3 months ago (2014-09-02 17:35:41 UTC) #5
egdaniel
Nit & math lgtm https://codereview.chromium.org/520123002/diff/20001/src/core/SkMatrix.cpp File src/core/SkMatrix.cpp (right): https://codereview.chromium.org/520123002/diff/20001/src/core/SkMatrix.cpp#newcode196 src/core/SkMatrix.cpp:196: SkASSERT(mask & (kAffine_Mask|kScale_Mask)); Nit: add ...
6 years, 3 months ago (2014-09-02 17:49:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/520123002/40001
6 years, 3 months ago (2014-09-02 20:08:07 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-02 20:15:44 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 17a845f76094eb3b5ac464556fced2a60dd0f088

Powered by Google App Engine
This is Rietveld 408576698