Issue 520023003: Revert of Revert of moar ws

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 520023003: Revert of Revert of moar ws (Closed)

Created:
6 years, 3 months ago by mtklein

Modified:
6 years, 3 months ago

Reviewers:
mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/) Reason for revert: nah Original issue's description: > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/) > > Reason for revert: > i like the old file better > > Original issue's description: > > moar ws > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9 > > TBR=mtklein@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2 TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56

Patch Set 1 #

Created: 6 years, 3 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	whitespace.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/520023003/1

6 years, 3 months ago (2014-08-30 01:33:21 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 5355536c790831f05cdd37a0ac84206ad1c3dc56

6 years, 3 months ago (2014-08-30 01:33:29 UTC) #3

mtklein

6 years, 3 months ago (2014-08-30 01:39:56 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/519303002/ by mtklein@google.com.

The reason for reverting is: spring break forever.

Expand Messages | Collapse Messages