Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 519903002: YCM works correctly when 'out' directory is a symlink. (Closed)

Created:
6 years, 3 months ago by dzhioev (left Google)
Modified:
6 years, 3 months ago
Reviewers:
eroman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

YCM works correctly when 'out' directory is a symlink. BUG=NONE TEST=manually NOTRY=true Committed: https://crrev.com/37accc2cd58a4f27f7cdd33907eae36f224bbb2e Cr-Commit-Position: refs/heads/master@{#292709}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M tools/vim/chromium.ycm_extra_conf.py View 2 chunks +6 lines, -5 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
dzhioev (left Google)
6 years, 3 months ago (2014-08-29 18:31:05 UTC) #2
eroman
lgtm https://codereview.chromium.org/519903002/diff/1/tools/vim/chromium.ycm_extra_conf.py File tools/vim/chromium.ycm_extra_conf.py (right): https://codereview.chromium.org/519903002/diff/1/tools/vim/chromium.ycm_extra_conf.py#newcode173 tools/vim/chromium.ycm_extra_conf.py:173: rel_filename = os.path.relpath(os.path.realpath(filename), much nicer!
6 years, 3 months ago (2014-08-29 19:23:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/519903002/1
6 years, 3 months ago (2014-08-29 22:00:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9ec92baa54b4d38bc709f900319f74d578feb4fe
6 years, 3 months ago (2014-08-29 23:12:30 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:11:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37accc2cd58a4f27f7cdd33907eae36f224bbb2e
Cr-Commit-Position: refs/heads/master@{#292709}

Powered by Google App Engine
This is Rietveld 408576698