pdf/control.cc - Issue 519873002: Avoid OOB memcpy in chrome_pdf::CopyImage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/control.cc

Issue 519873002: Avoid OOB memcpy in chrome_pdf::CopyImage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix underlying math bug. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/control.cc

diff --git a/pdf/control.cc b/pdf/control.cc

index 12bb7ed1689f872611f45124b139c33563d40891..ed911b6b95a521ae1793b94300dffb97a84054ca 100644

--- a/pdf/control.cc

+++ b/pdf/control.cc

@@ -53,7 +53,7 @@ void Control::PaintMultipleRects(pp::ImageData* image_data,

return;

pp::Rect draw_rc = pp::Rect(image_data->size()).Intersect(rect());

- pp::Rect ctrl_rc = pp::Rect(rect().point() - draw_rc.point(), draw_rc.size());

+ pp::Rect ctrl_rc = pp::Rect(draw_rc.point() - rect().point(), draw_rc.size());

CopyImage(*image_data, draw_rc, &buffer, ctrl_rc, false);

// Temporary move control to origin (0,0) and draw it into temp buffer.

« no previous file with comments | « no previous file | pdf/draw_utils.cc » ('j') | ppapi/cpp/image_data.h » ('J')