Avoid OOB memcpy in chrome_pdf::CopyImage.

ppapi/cpp/image_data.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_CPP_IMAGE_DATA_H_
 #define PPAPI_CPP_IMAGE_DATA_H_
 
 #include "ppapi/c/ppb_image_data.h"
 #include "ppapi/cpp/point.h"
+#include "ppapi/cpp/rect.h"
+#include "ppapi/cpp/resource.h"
 #include "ppapi/cpp/size.h"
-#include "ppapi/cpp/resource.h"
 
 /// @file
 /// This file defines the APIs for determining how a browser
 /// handles image data.
 namespace pp {
 
 class InstanceHandle;
 
 class ImageData : public Resource {
  public:
@@ skipping 100 matching lines @@
 
   /// This function is used retrieve the address of the given pixel for 32-bit
   /// pixel formats.
   ///
   /// @param[in] coord A <code>Point</code> representing the x and y
   /// coordinates for a specific pixel.
   ///
   /// @return The address for the pixel.
   uint32_t* GetAddr32(const Point& coord);
 
+  /// This function determines if a rectangle's dimensions are fully contained
+  /// within the boundaries of the image.
+  ///
+  /// @param[in] rect A <code>Rect</code> representing the rectangle to check.
+  ///
+  /// @return True if fully contained, false otherwise.
+  bool Contains(const pp::Rect& rect) const;

[raymes, 2014/09/01 00:42:17]

Technically this is a change to the public API. We haven't needed this in the
long history of pp::ImageData, do you think we will start to need it a lot more?
If not, I think it might be better just to move a helper function into the place
where it's used. 

What do you think? :)

+
  private:
   void InitData();
 
   PP_ImageDataDesc desc_;
   void* data_;
 };
 
 }  // namespace pp
 
 #endif  // PPAPI_CPP_IMAGE_DATA_H_