Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: Source/build/scripts/templates/MakeQualifiedNames.h.tmpl

Issue 51983003: Stop using static arrays for *Tags / *Attrs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve generated code Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/build/scripts/templates/MakeQualifiedNames.h.tmpl
diff --git a/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl b/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl
index 7c614c787b4ed0d79627da08d0fa4204443c70dd..497658268f749019c92cfe84e5313b88f7544379 100644
--- a/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl
+++ b/Source/build/scripts/templates/MakeQualifiedNames.h.tmpl
@@ -27,10 +27,10 @@ extern const WebCore::QualifiedName {{attr|symbol}}Attr;
{%- if tags %}
const unsigned {{namespace}}TagsCount = {{tags|count}};
-const WebCore::QualifiedName* const* get{{namespace}}Tags();
+void get{{namespace}}Tags(Vector<const WebCore::QualifiedName*>& tags);
Inactive 2013/10/30 18:35:36 iirc, we decided on the mailing list to not rely o
{%- endif %}
const unsigned {{namespace}}AttrsCount = {{attrs|count}};
-const WebCore::QualifiedName* const* get{{namespace}}Attrs();
+void get{{namespace}}Attrs(Vector<const WebCore::QualifiedName*>& attrs);
void init();

Powered by Google App Engine
This is Rietveld 408576698