Chromium Code Reviews| Index: Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl |
| diff --git a/Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl b/Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl |
| index e6ff66955bfff4326bb67f4bfa05baa0da80727e..877bf329ade69ff746f96d656288a3ffd84f913a 100644 |
| --- a/Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl |
| +++ b/Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl |
| @@ -28,14 +28,13 @@ DEFINE_GLOBAL(QualifiedName, {{tag|symbol}}Tag) |
| {%- endfor %} |
| -const WebCore::QualifiedName* const* get{{namespace}}Tags() |
| +void get{{namespace}}Tags(Vector<const WebCore::QualifiedName*>& tags) |
|
digit1
2013/11/08 16:30:16
The Chromium style guide forbids non-constant refe
|
| { |
| - static const WebCore::QualifiedName* const {{namespace}}Tags[] = { |
| + tags.clear(); |
| + tags.reserveCapacity({{namespace}}TagsCount); |
| {%- for tag in tags|sort %} |
| - (WebCore::QualifiedName*)&{{tag|symbol}}Tag, |
| + tags.uncheckedAppend((WebCore::QualifiedName*)&{{tag|symbol}}Tag); |
| {%- endfor %} |
| - }; |
| - return {{namespace}}Tags; |
| } |
| {%- endif %} |
| @@ -45,14 +44,13 @@ const WebCore::QualifiedName* const* get{{namespace}}Tags() |
| DEFINE_GLOBAL(QualifiedName, {{attr|symbol}}Attr) |
| {%- endfor %} |
| -const WebCore::QualifiedName* const* get{{namespace}}Attrs() |
| +void get{{namespace}}Attrs(Vector<const WebCore::QualifiedName*>& attrs) |
| { |
| - static const WebCore::QualifiedName* const {{namespace}}Attrs[] = { |
| + attrs.clear(); |
| + attrs.reserveCapacity({{namespace}}AttrsCount); |
| {%- for attr in attrs|sort %} |
| - (WebCore::QualifiedName*)&{{attr|symbol}}Attr, |
| + attrs.uncheckedAppend((WebCore::QualifiedName*)&{{attr|symbol}}Attr); |
| {%- endfor %} |
| - }; |
| - return {{namespace}}Attrs; |
| } |
| void init() |