media/filters/source_buffer_stream.cc - Issue 51983002: Update selected range after truncation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/source_buffer_stream.cc

Issue 51983002: Update selected range after truncation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/source_buffer_stream.cc

diff --git a/media/filters/source_buffer_stream.cc b/media/filters/source_buffer_stream.cc

index c9a702c6a6fd730ec316cb188a6b80f040aff5f8..e70faf80415c358c62fd73857bb49cf0b613dc1e 100644

--- a/media/filters/source_buffer_stream.cc

+++ b/media/filters/source_buffer_stream.cc

@@ -1068,6 +1068,8 @@ void SourceBufferStream::OnSetDuration(base::TimeDelta duration) {

// Need to partially truncate this range.

if ((*itr)->GetStartTimestamp() < duration) {

(*itr)->TruncateAt(duration, NULL, false);

+ if (selected_range_ && !selected_range_->HasNextBufferPosition())

acolwell GONE FROM CHROMIUM 2013/11/04 20:58:11 nit: s/selected_range_ &&/(*itr == selected_range_

Jinsuk Kim 2013/11/05 03:31:49 Done.

+ SetSelectedRange(NULL);

++itr;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »