Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 519823002: Clang/Windows update script: copy the dynamic ASan RTL if present (Closed)

Created:
6 years, 3 months ago by Timur Iskhodzhanov
Modified:
6 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clang/Windows update script: copy the dynamic ASan RTL if present BUG=345874 NOTRY=true Committed: https://crrev.com/04a15eeb2cee36d202fc92e6ab62dd44454d0cac Cr-Commit-Position: refs/heads/master@{#292653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M tools/clang/scripts/update.py View 2 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hans
hans@chromium.org changed reviewers: + hans@chromium.org
6 years, 3 months ago (2014-08-29 16:38:51 UTC) #1
hans
lgtm (looks like this migrated from https://codereview.chromium.org/524623003/)
6 years, 3 months ago (2014-08-29 16:38:51 UTC) #2
Timur Iskhodzhanov
The CQ bit was checked by timurrrr@chromium.org
6 years, 3 months ago (2014-08-29 16:39:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/519823002/1
6 years, 3 months ago (2014-08-29 16:40:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 632c096a2141c17b29788b46cfda68c3a35a560a
6 years, 3 months ago (2014-08-29 16:41:23 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:09:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04a15eeb2cee36d202fc92e6ab62dd44454d0cac
Cr-Commit-Position: refs/heads/master@{#292653}

Powered by Google App Engine
This is Rietveld 408576698