Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 519773002: Fix out-of-bounds read in RegistryOverrideManager. (Closed)

Created:
6 years, 3 months ago by grt (UTC plus 2)
Modified:
6 years, 3 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix out-of-bounds read in RegistryOverrideManager. This fixes a class of test flakes that impacts all Windows tests that use registry_util::RegistryOverrideManager. BUG=none R=phajdan.jr@chromium.org Committed: https://crrev.com/03329dbee50f175284da0101599446e6a89e04fd Cr-Commit-Position: refs/heads/master@{#292665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/test/test_reg_util_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
grt (UTC plus 2)
6 years, 3 months ago (2014-08-29 15:13:47 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 3 months ago (2014-08-29 16:29:03 UTC) #2
grt (UTC plus 2)
The CQ bit was checked by grt@chromium.org
6 years, 3 months ago (2014-08-29 16:42:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/519773002/1
6 years, 3 months ago (2014-08-29 16:44:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 924469da54b61ddd3f9eb54c5bafb42b6b4767ca
6 years, 3 months ago (2014-08-29 17:49:56 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:09:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03329dbee50f175284da0101599446e6a89e04fd
Cr-Commit-Position: refs/heads/master@{#292665}

Powered by Google App Engine
This is Rietveld 408576698