Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 519713002: [turbofan] Allow unittest to call TruncateDoubleToI. (Closed)

Created:
6 years, 3 months ago by Rodolph Perfetta (ARM)
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Allow unittest to call TruncateDoubleToI. Switches stack pointer if necessary. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M src/arm64/macro-assembler-arm64.cc View 2 chunks +20 lines, -3 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Rodolph Perfetta (ARM)
rodolph.perfetta@arm.com changed reviewers: + bmeurer@chromium.org
6 years, 3 months ago (2014-08-29 12:49:54 UTC) #1
Rodolph Perfetta (ARM)
I will re enable the truncating lowering tests in a separate patch.
6 years, 3 months ago (2014-08-29 12:49:54 UTC) #2
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-08-29 18:08:47 UTC) #3
Rodolph Perfetta (ARM)
6 years, 3 months ago (2014-08-29 18:46:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698