Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: Source/bindings/scripts/compute_interfaces_info_overall.py

Issue 519703002: Add [NoImplHeader] extended attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # 2 #
3 # Copyright (C) 2013 Google Inc. All rights reserved. 3 # Copyright (C) 2013 Google Inc. All rights reserved.
4 # 4 #
5 # Redistribution and use in source and binary forms, with or without 5 # Redistribution and use in source and binary forms, with or without
6 # modification, are permitted provided that the following conditions are 6 # modification, are permitted provided that the following conditions are
7 # met: 7 # met:
8 # 8 #
9 # * Redistributions of source code must retain the above copyright 9 # * Redistributions of source code must retain the above copyright
10 # notice, this list of conditions and the following disclaimer. 10 # notice, this list of conditions and the following disclaimer.
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 raise IdlInterfaceFileNotFoundError('Could not find the IDL file whe re the following implemented interface is defined: %s' % key_name) 221 raise IdlInterfaceFileNotFoundError('Could not find the IDL file whe re the following implemented interface is defined: %s' % key_name)
222 implemented_interfaces_full_paths = [ 222 implemented_interfaces_full_paths = [
223 implemented_interface_info['full_path'] 223 implemented_interface_info['full_path']
224 for implemented_interface_info in implemented_interfaces_info] 224 for implemented_interface_info in implemented_interfaces_info]
225 # Implemented interfaces don't need includes, as this is handled in 225 # Implemented interfaces don't need includes, as this is handled in
226 # the Blink implementation (they are implemented on |impl| itself, 226 # the Blink implementation (they are implemented on |impl| itself,
227 # hence header is included in implementing class). 227 # hence header is included in implementing class).
228 # However, they are needed for legacy implemented interfaces that 228 # However, they are needed for legacy implemented interfaces that
229 # are being treated as partial interfaces, until we remove these. 229 # are being treated as partial interfaces, until we remove these.
230 # http://crbug.com/360435 230 # http://crbug.com/360435
231 implemented_interfaces_include_paths = [ 231 implemented_interfaces_include_paths = []
232 implemented_interface_info['include_path'] 232 for implemented_interface_info in implemented_interfaces_info:
233 for implemented_interface_info in implemented_interfaces_info 233 if (implemented_interface_info['is_legacy_treat_as_partial_interface '] and
234 if implemented_interface_info['is_legacy_treat_as_partial_interface' ]] 234 implemented_interface_info['include_path']):
235 implemented_interfaces_include_paths.append(implemented_interfac e_info['include_path'])
235 236
236 interface_info.update({ 237 interface_info.update({
237 'dependencies_full_paths': (partial_interfaces_full_paths + 238 'dependencies_full_paths': (partial_interfaces_full_paths +
238 implemented_interfaces_full_paths), 239 implemented_interfaces_full_paths),
239 'dependencies_include_paths': (partial_interfaces_include_paths + 240 'dependencies_include_paths': (partial_interfaces_include_paths +
240 implemented_interfaces_include_paths) , 241 implemented_interfaces_include_paths) ,
241 }) 242 })
242 243
243 # Clean up temporary private information 244 # Clean up temporary private information
244 for interface_info in interfaces_info.itervalues(): 245 for interface_info in interfaces_info.itervalues():
(...skipping 11 matching lines...) Expand all
256 info_individuals = read_pickle_files(args) 257 info_individuals = read_pickle_files(args)
257 258
258 compute_interfaces_info_overall(info_individuals) 259 compute_interfaces_info_overall(info_individuals)
259 write_pickle_file(interfaces_info_filename, 260 write_pickle_file(interfaces_info_filename,
260 interfaces_info, 261 interfaces_info,
261 options.write_file_only_if_changed) 262 options.write_file_only_if_changed)
262 263
263 264
264 if __name__ == '__main__': 265 if __name__ == '__main__':
265 sys.exit(main()) 266 sys.exit(main())
OLDNEW
« no previous file with comments | « Source/bindings/scripts/compute_interfaces_info_individual.py ('k') | Source/core/testing/PartialPrivateScriptTest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698