Default values for enterprise users are supported.

components/policy/tools/generate_policy_source.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 '''python %prog [options] platform chromium_os_flag template
 
 platform specifies which platform source is being generated for
   and can be one of (win, mac, linux)
 chromium_os_flag should be 1 if this is a Chromium OS build
@@ skipping 39 matching lines @@
     def __init__(self, item):
       self.caption = PolicyDetails._RemovePlaceholders(item['caption'])
       self.value = item['value']
 
   def __init__(self, policy, os, is_chromium_os):
     self.id = policy['id']
     self.name = policy['name']
     self.is_deprecated = policy.get('deprecated', False)
     self.is_device_only = policy.get('device_only', False)
     self.schema = policy.get('schema', {})
+    self.has_enterprise_default = 'default_for_enterprise_users' in policy
+    if self.has_enterprise_default:
+      self.enterprise_default = policy['default_for_enterprise_users']
 
     expected_platform = 'chrome_os' if is_chromium_os else os.lower()
     self.platforms = []
     for platform, version in [ p.split(':') for p in policy['supported_on'] ]:
       if not version.endswith('-'):
         continue
 
       if platform.startswith('chrome.'):
         platform_sub = platform[7:]
         if platform_sub == '*':
@@ skipping 158 matching lines @@
             'configuration resides.\n'
             'extern const wchar_t kRegistryChromePolicyKey[];\n')
 
   f.write('// Returns the PolicyDetails for |policy| if |policy| is a known\n'
           '// Chrome policy, otherwise returns NULL.\n'
           'const PolicyDetails* GetChromePolicyDetails('
               'const std::string& policy);\n'
           '\n'
           '// Returns the schema data of the Chrome policy schema.\n'
           'const internal::SchemaData* GetChromeSchemaData();\n'
           '\n')

[Joao da Silva, 2014/08/29 09:11:42]

Add a forward declaration for SetEnterpriseUsersDefaults here, wrapped in #ifdef
OS_CHROMEOS

[merkulova, 2014/08/29 14:02:52]

Done.

   f.write('// Key names for the policy settings.\n'
           'namespace key {\n\n')
   for policy in policies:
     # TODO(joaodasilva): Include only supported policies in
     # configuration_policy_handler.cc and configuration_policy_handler_list.cc
     # so that these names can be conditional on 'policy.is_supported'.
     # http://crbug.com/223616
     f.write('extern const char k' + policy.name + '[];\n')
   f.write('\n}  // namespace key\n\n'
           '}  // namespace policy\n\n'
@@ skipping 317 matching lines @@
         self.properties_nodes)
 
 def _WritePolicyConstantSource(policies, os, f):
   f.write('#include "policy/policy_constants.h"\n'
           '\n'
           '#include <algorithm>\n'
           '#include <climits>\n'
           '\n'
           '#include "base/logging.h"\n'
           '#include "components/policy/core/common/schema_internal.h"\n'
+          '#include "components/policy/core/common/policy_map.h"\n'

[Joao da Silva, 2014/08/29 09:11:42]

Includes in alphabetical order, so this comes before schema_internal.h

[merkulova, 2014/08/29 14:02:53]

Done.

           '\n'
           'namespace policy {\n'
           '\n'
           'namespace {\n'
           '\n')
 
   # Generate the Chrome schema.
   chrome_schema = {
     'type': 'object',
     'properties': {},
@@ skipping 37 matching lines @@
             'L"' + CHROME_POLICY_KEY + '";\n'
             '#else\n'
             'const wchar_t kRegistryChromePolicyKey[] = '
             'L"' + CHROMIUM_POLICY_KEY + '";\n'
             '#endif\n\n')
 
   f.write('const internal::SchemaData* GetChromeSchemaData() {\n'
           '  return &kChromeSchemaData;\n'
           '}\n\n')
 
+  f.write('#if defined(OS_CHROMEOS)\n'
+          'void SetEnterpriseUsersDefaults(PolicyMap* policy_map) {\n')
+
+  for policy in policies:
+      if policy.has_enterprise_default:

[Joao da Silva, 2014/08/29 09:11:42]

Use 2 spaces for indentation instead of 4 (below too)

[merkulova, 2014/08/29 14:02:53]

Done.

+          if policy.policy_type == 'TYPE_BOOLEAN':
+              creation_expression = 'new bool(%s)' % policy.enterprise_default

[Joao da Silva, 2014/08/29 09:11:43]

new base::FundamentalValue()

Also, the |policy.enterprise_default| value is a python boolean, so it's True or
False. It needs to be converted to the C++ keywords in lowercase. Suggestion:

'new base::FundamentalValue(%s)' % (policy.enterprise_default and 'true' else
'false')

[merkulova, 2014/08/29 14:02:53]

Done.

+          elif policy.policy_type == 'TYPE_INTEGER':
+              creation_expression = 'new int(%s)' % policy.enterprise_default

[Joao da Silva, 2014/08/29 09:11:42]

new base::FundamentalValue

[merkulova, 2014/08/29 14:02:52]

Done.

+          elif policy.policy_type == 'TYPE_STRING':
+              creation_expression = 'new base::StringValue("%s")' %\
+                                    policy.enterprise_default
+          else:
+              raise RuntimeError('Type %s of policy %s is not supported at '
+                                 'enterprise defaults' % (policy.policy_type,
+                                                          policy.name))
+          f.write('  if (!policy_map->Get("%s")) {\n'
+                  '    policy_map->Set("%s",\n'

[Joao da Silva, 2014/08/29 09:11:42]

These 2 lines are duplicating the string for the policy name. We can use the
constant in the policy::key namespace instead (these are generated below, in
line 694)

You can just replace Get("%s") and Set("%s" with something like Get(key::k%s)
and Set(key::k%s

[merkulova, 2014/08/29 14:02:52]

Done.

+                  '                    POLICY_LEVEL_MANDATORY,\n'
+                  '                    POLICY_SCOPE_USER,\n'
+                  '                    %s,\n'
+                  '                    NULL);\n'
+                  '  }\n' % (policy.name, policy.name, creation_expression))
+
+  f.write('}\n\n'

[Joao da Silva, 2014/08/29 09:11:42]

Single newline here, so that the #endif comes right after the end of the
function (the opening #ifdef is also right next to the start)

[merkulova, 2014/08/29 14:02:52]

Done.

+          '#endif\n\n')
+
   f.write('const PolicyDetails* GetChromePolicyDetails('
               'const std::string& policy) {\n'
           '  // First index in kPropertyNodes of the Chrome policies.\n'
           '  static const int begin_index = %s;\n'
           '  // One-past-the-end of the Chrome policies in kPropertyNodes.\n'
           '  static const int end_index = %s;\n' %
           (schema_generator.root_properties_begin,
            schema_generator.root_properties_end))
   f.write('  const internal::PropertyNode* begin =\n'
           '      kPropertyNodes + begin_index;\n'
@@ skipping 276 matching lines @@
 def _WriteCloudPolicyDecoder(policies, os, f):
   f.write(CPP_HEAD)
   for policy in policies:
     if policy.is_supported and not policy.is_device_only:
       _WritePolicyCode(f, policy)
   f.write(CPP_FOOT)
 
 
 if __name__ == '__main__':
   sys.exit(main())