Use the solid color detection to create solid layers

cc/layers/picture_layer.h

Index: cc/layers/picture_layer.h
diff --git a/cc/layers/picture_layer.h b/cc/layers/picture_layer.h
index 80bb4d867a6b01ff5c50a390fb835b0735a3a81a..54d5c206059fa40a545992c68c464b2f853fcc4c 100644
--- a/cc/layers/picture_layer.h
+++ b/cc/layers/picture_layer.h
@@ -16,6 +16,7 @@ namespace cc {
 
 class ContentLayerClient;
 class ResourceUpdateQueue;
+class PictureLayerImpl;
 
 class CC_EXPORT PictureLayer : public Layer {
  public:
@@ -51,6 +52,8 @@ class CC_EXPORT PictureLayer : public Layer {
   virtual bool HasDrawableContent() const OVERRIDE;
   void UpdateCanUseLCDText();
 
+  virtual void SetSolidColorPropertiesTo(PictureLayerImpl* layer_impl) const;

[vmpstr, 2014/08/29 06:49:14]

Why virtual?

[hendrikw, 2014/08/29 14:03:21]

There are four tests in layer try host unit test which set
SetMaxTransferBufferUsageBytes, to some value, then tests against that value. 
Obviously now, when we play the layer, it gets detected as solid and doesn't
draw to any gles textures, so it never gets the chance to test the buffer usage
(it returns zero).  I'm using this as a way to override the solid color state
for the fake picture layer used in the test :/

[vmpstr, 2014/08/29 14:20:44]

Ah ok. Can you leave a "Virtual for testing." comment here?

[enne (OOO), 2014/08/29 16:53:43]

Virtual for testing.  :(

Can you make the fake picture layer not detected as solid in that test?

[hendrikw, 2014/09/02 14:19:17]

I found a way to do the same thing without the virtual

+
  private:
   ContentLayerClient* client_;
   scoped_refptr<PicturePile> pile_;