Use the solid color detection to create solid layers

cc/test/fake_picture_layer.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/fake_picture_layer.h"
 
 #include "cc/test/fake_picture_layer_impl.h"
 
 namespace cc {
 
@@ skipping 15 matching lines @@
 
 bool FakePictureLayer::Update(ResourceUpdateQueue* queue,
                               const OcclusionTracker<Layer>* occlusion) {
   bool updated = PictureLayer::Update(queue, occlusion);
   update_count_++;
   return updated || always_update_resources_;
 }
 
 void FakePictureLayer::PushPropertiesTo(LayerImpl* layer) {
   PictureLayer::PushPropertiesTo(layer);
+  PictureLayerImpl* layer_impl = static_cast<PictureLayerImpl*>(layer);
+  // the tests expect a non-solid layer

[danakj, 2014/09/10 18:46:40]

Comments should be complete sentence including capitals and punctuation.

[hendrikw, 2014/09/11 00:27:40]

Acknowledged.

+  layer_impl->SetSolidColorState(false, SK_ColorBLACK);

[danakj, 2014/09/10 18:46:40]

This seems awkward. Maybe we should make FakeContentLayerClient not draw a solid
color by default and add a bool that lets you override it with a solid color
instead if needed?

[hendrikw, 2014/09/11 00:27:40]

Hmm, well, the test does require a solid color to be rendered via the non-solid
code path, so the case you are describing never exists :)  I agree, awkward is a
good word for this.  If I remember correctly, the test is setting some max
buffer size, and then checks that after we render, we never use more than that
buffer size.  If the layer is solid, we no longer render to a buffer, so the
test no longer works.

I suppose I could replace the solid render with something else, but that would
probably be even more awkward :(

[danakj, 2014/09/11 23:43:50]

You need a layer with a solid color with a pile that says it's not solid color?
I'm confused by this, the test sounds weird?
It would be more realistic though, doing like an alternating of 2 colors every
other pixel or something. Previously all our tests were built assuming painting
=> tiles with resources. Making that the default behaviour still by actually
providing content that causes that seems nicer than overriding some behaviour on
PLI here. What happens when a test wants to make a picture layer with solid
color pile and see the result be solid color with no resources on the impl side?
This totally blocks that.

   push_properties_count_++;
 }
 
 
 }  // namespace cc