Use the solid color detection to create solid layers

cc/layers/picture_layer.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/picture_layer.h"
 
 #include "base/auto_reset.h"
 #include "cc/layers/content_layer_client.h"
 #include "cc/layers/picture_layer_impl.h"
 #include "cc/trees/layer_tree_impl.h"
@@ skipping 18 matching lines @@
 }
 
 scoped_ptr<LayerImpl> PictureLayer::CreateLayerImpl(LayerTreeImpl* tree_impl) {
   return PictureLayerImpl::Create(tree_impl, id()).PassAs<LayerImpl>();
 }
 
 void PictureLayer::PushPropertiesTo(LayerImpl* base_layer) {
   Layer::PushPropertiesTo(base_layer);
   PictureLayerImpl* layer_impl = static_cast<PictureLayerImpl*>(base_layer);
 
+  layer_impl->SetSolidColorState(pile_->IsSolidColor(), pile_->GetSolidColor());

[danakj, 2014/09/10 18:40:50]

can the layerimpl not pull this off its own pile instead of adding these class
members which just double the ones on the PLI's pile?

[hendrikw, 2014/09/11 00:27:40]

PLI doesn't know if it's solid or not (only PL knows this).  Besides, I need
this function to override the solid state for the test code.

[danakj, 2014/09/11 23:36:37]

Can't the test set the bool in the pile? Take a look at the is_mask_ in pile for
an example. PLI uses that to change behaviour. And tests set it on the pile to
change behaviour.

+
   if (layer_impl->bounds().IsEmpty()) {
     // Update may not get called for an empty layer, so resize here instead.
     // Using layer_impl because either bounds() or paint_properties().bounds
     // may disagree and either one could have been pushed to layer_impl.
     pile_->SetEmptyBounds();
   } else if (update_source_frame_number_ ==
              layer_tree_host()->source_frame_number()) {
     // TODO(ernstm): This DCHECK is only valid as long as the pile's tiling_rect
     // is identical to the layer_rect.
     // If update called, then pile size must match bounds pushed to impl layer.
@@ skipping 156 matching lines @@
 
 bool PictureLayer::HasDrawableContent() const {
   return client_ && Layer::HasDrawableContent();
 }
 
 void PictureLayer::RunMicroBenchmark(MicroBenchmark* benchmark) {
   benchmark->RunOnLayer(this);
 }
 
 }  // namespace cc