Use the solid color detection to create solid layers

cc/trees/layer_tree_host_pixeltest_readback.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 #include "cc/layers/solid_color_layer.h"
 #include "cc/layers/texture_layer.h"
 #include "cc/output/copy_output_request.h"
 #include "cc/output/copy_output_result.h"
 #include "cc/test/fake_picture_layer.h"
@@ skipping 913 matching lines @@
     // Cause the device scale factor to be inherited by contents scales.
     settings->layer_transforms_should_scale_layer_contents = true;
   }
 
   virtual void SetupTree() OVERRIDE {
     layer_tree_host()->SetDeviceScaleFactor(device_scale_factor_);
     LayerTreePixelTest::SetupTree();
   }
 
   virtual void DrawLayersOnThread(LayerTreeHostImpl* host_impl) OVERRIDE {
     LayerImpl* root_impl = host_impl->active_tree()->root_layer();

[danakj, 2014/09/15 16:26:35]

Just remove all these layers, they're unused.

[hendrikw, 2014/09/15 16:59:40]

Acknowledged.

+    EXPECT_EQ(device_scale_factor_,
+              host_impl->active_tree()->device_scale_factor());
 
     FakePictureLayerImpl* background_impl =
         static_cast<FakePictureLayerImpl*>(root_impl->children()[0]);
-    EXPECT_EQ(device_scale_factor_,
-              background_impl->HighResTiling()->contents_scale());

[vmpstr, 2014/09/15 15:45:08]

Why this change?

[danakj, 2014/09/15 16:26:35]

This test makes solid color quads now so it has no tilings. It's still testing a
readback with a DSF so I think that's fine.

[hendrikw, 2014/09/15 16:59:40]

Because we no longer have HiResTiling(), i.e. it is nullptr, the layer is solid.

-
     FakePictureLayerImpl* green_impl =
         static_cast<FakePictureLayerImpl*>(background_impl->children()[0]);
-    EXPECT_EQ(device_scale_factor_,
-              green_impl->HighResTiling()->contents_scale());
-
     FakePictureLayerImpl* blue_impl =
         static_cast<FakePictureLayerImpl*>(green_impl->children()[0]);
-    EXPECT_EQ(device_scale_factor_,
-              blue_impl->HighResTiling()->contents_scale());
   }
 
   float device_scale_factor_;
   SolidColorContentLayerClient white_client_;
   SolidColorContentLayerClient green_client_;
   SolidColorContentLayerClient blue_client_;
 };
 
 TEST_F(LayerTreeHostReadbackDeviceScalePixelTest,
        ReadbackSubrect_Software) {
@@ skipping 134 matching lines @@
                                  background,
                                  green.get(),
                                  base::FilePath(FILE_PATH_LITERAL(
                                      "green_with_blue_corner.png")));
 }
 
 }  // namespace
 }  // namespace cc
 
 #endif  // OS_ANDROID