Use the solid color detection to create solid layers

cc/layers/picture_layer_impl_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/picture_layer_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <set>
 #include <utility>
@@ skipping 252 matching lines @@
       // This test verifies that when drawing the contents of a specific tile
       // at content scale 1.0, the playback canvas never receives content from
       // neighboring tiles which indicates that the tile grid embedded in
       // SkPicture is perfectly aligned with the compositor's tiles.
       EXPECT_EQ(1u, mock_canvas.rects_.size());
       EXPECT_RECT_EQ(*rect_iter, mock_canvas.rects_[0]);
       rect_iter++;
     }
   }
 
+  void TestQuadsForSolidColor(bool test_for_solid) {

[danakj, 2014/09/15 16:26:35]

This code is soo far away from the actual tests. Can you just make a
PictureLayerImplTest subclass down by the actual tests and move this function
there?

[hendrikw, 2014/09/15 16:59:40]

Acknowledged.

+    base::TimeTicks time_ticks;
+    time_ticks += base::TimeDelta::FromMilliseconds(1);
+    host_impl_.SetCurrentBeginFrameArgs(
+        CreateBeginFrameArgsForTesting(time_ticks));
+
+    gfx::Size tile_size(100, 100);
+    gfx::Size layer_bounds(200, 200);
+    gfx::Rect layer_rect(layer_bounds);
+
+    FakeContentLayerClient client;
+    scoped_refptr<PictureLayer> layer = PictureLayer::Create(&client);
+    scoped_ptr<FakeLayerTreeHost> host = FakeLayerTreeHost::Create();
+    host->SetRootLayer(layer);
+    PicturePile* pile = layer->GetPicturePileForTesting();
+
+    host_impl_.SetViewportSize(layer_bounds);
+
+    int frame_number = 0;
+    FakeRenderingStatsInstrumentation stats_instrumentation;
+
+    client.set_fill_with_nonsolid_color(!test_for_solid);
+
+    Region invalidation(layer_rect);
+    pile->UpdateAndExpandInvalidation(&client,
+                                      &invalidation,
+                                      SK_ColorWHITE,
+                                      false,
+                                      false,
+                                      layer_bounds,
+                                      layer_rect,
+                                      frame_number++,
+                                      Picture::RECORD_NORMALLY,
+                                      &stats_instrumentation);
+
+    scoped_refptr<PicturePileImpl> pending_pile =
+        PicturePileImpl::CreateFromOther(pile);
+
+    SetupPendingTree(pending_pile);
+    ActivateTree();
+
+    if (test_for_solid) {
+      EXPECT_EQ(0, active_layer_->tilings()->num_tilings());
+    } else {
+      active_layer_->set_fixed_tile_size(tile_size);
+      host_impl_.active_tree()->UpdateDrawProperties();
+      std::vector<Tile*> tiles =

[vmpstr, 2014/09/15 15:45:07]

you should ASSERT_TRUE(active_layer_->tilings()); and
ASSERT_GT(active_layer_->tilings()->num_tilings(), 0u); to ensure that if the
test is to fail, it won't just crash.

[hendrikw, 2014/09/15 16:59:40]

Acknowledged.

But a failure in a test doesn't prevent the rest of the test from being
executed.  Would you also like me to add if statements to prevent possible
crashes?

[danakj, 2014/09/15 17:01:22]

An EXPECT_FOO failure continues the test. An ASSERT_FOO failure exits the test.

+          active_layer_->tilings()->tiling_at(0)->AllTilesForTesting();
+      EXPECT_FALSE(tiles.empty());
+      host_impl_.tile_manager()->InitializeTilesWithResourcesForTesting(tiles);
+    }
+
+    MockOcclusionTracker<LayerImpl> occlusion_tracker;
+    scoped_ptr<RenderPass> render_pass = RenderPass::Create();
+    AppendQuadsData data;
+    active_layer_->WillDraw(DRAW_MODE_SOFTWARE, NULL);
+    active_layer_->AppendQuads(render_pass.get(), occlusion_tracker, &data);
+    active_layer_->DidDraw(NULL);
+
+    DrawQuad::Material expected = test_for_solid
+                                      ? DrawQuad::Material::SOLID_COLOR
+                                      : DrawQuad::Material::TILED_CONTENT;
+    EXPECT_EQ(expected, render_pass->quad_list.front()->material);
+  }
+
   FakeImplProxy proxy_;
   TestSharedBitmapManager shared_bitmap_manager_;
   FakeLayerTreeHostImpl host_impl_;
   int id_;
   FakePictureLayerImpl* pending_layer_;
   FakePictureLayerImpl* old_pending_layer_;
   FakePictureLayerImpl* active_layer_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PictureLayerImplTest);
@@ skipping 3932 matching lines @@
   EXPECT_FALSE(active_layer_->GetRecycledTwinLayer());
 
   ActivateTree();
   EXPECT_TRUE(active_layer_->GetRecycledTwinLayer());
   EXPECT_EQ(old_pending_layer_, active_layer_->GetRecycledTwinLayer());
 
   host_impl_.ResetRecycleTreeForTesting();
   EXPECT_FALSE(active_layer_->GetRecycledTwinLayer());
 }
 
+TEST_F(PictureLayerImplTest, DrawSolidQuads) {
+  TestQuadsForSolidColor(true);
+}
+
+TEST_F(PictureLayerImplTest, DrawNonSolidQuads) {
+  TestQuadsForSolidColor(false);
+}
+
 }  // namespace
 }  // namespace cc