Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 519533002: Initial PlzNavigate RDH-side logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 7bde6cd9a54537e86539b1e3179fd99286986710..7fbc248b11ba6ad0388dd61a16fc30bf61be6ba4 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -8,7 +8,6 @@
#include "base/time/time.h"
#include "content/browser/frame_host/frame_tree.h"
#include "content/browser/frame_host/frame_tree_node.h"
-#include "content/browser/frame_host/navigation_before_commit_info.h"
#include "content/browser/frame_host/navigation_controller_impl.h"
#include "content/browser/frame_host/navigation_entry_impl.h"
#include "content/browser/frame_host/navigator_delegate.h"
@@ -27,6 +26,7 @@
#include "content/public/browser/navigation_details.h"
#include "content/public/browser/page_navigator.h"
#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/stream_handle.h"
#include "content/public/common/bindings_policy.h"
#include "content/public/common/content_client.h"
#include "content/public/common/content_switches.h"
@@ -662,13 +662,14 @@ void NavigatorImpl::RequestTransferURL(
delegate_->RequestOpenURL(render_frame_host, params);
}
-void NavigatorImpl::CommitNavigation(
- RenderFrameHostImpl* render_frame_host,
- const NavigationBeforeCommitInfo& info) {
- CheckWebUIRendererDoesNotDisplayNormalURL(
- render_frame_host, info.navigation_url);
+void NavigatorImpl::CommitNavigation(RenderFrameHostImpl* render_frame_host,
+ const GURL& url,
+ ResourceResponse* response,
+ scoped_ptr<StreamHandle> body) {
+ CheckWebUIRendererDoesNotDisplayNormalURL(render_frame_host, url);
// TODO(clamy): the render_frame_host should now send a commit IPC to the
// renderer.
+ NOTIMPLEMENTED();
}
void NavigatorImpl::CheckWebUIRendererDoesNotDisplayNormalURL(

Powered by Google App Engine
This is Rietveld 408576698