content/browser/loader/resource_loader_unittest.cc - Issue 51953002: [Net] Add a priority parameter to URLRequest's constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_loader_unittest.cc

Issue 51953002: [Net] Add a priority parameter to URLRequest's constructor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compile error from rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc ('K') | « content/browser/loader/resource_dispatcher_host_unittest.cc ('k') | content/browser/loader/resource_scheduler_unittest.cc » ('j') | net/url_request/url_request_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_loader_unittest.cc

diff --git a/content/browser/loader/resource_loader_unittest.cc b/content/browser/loader/resource_loader_unittest.cc

index d228300968d47cdb670b691ecb9ac745cba91cd3..4373497667bdbc770eda03b76861733cae50f6d0 100644

--- a/content/browser/loader/resource_loader_unittest.cc

+++ b/content/browser/loader/resource_loader_unittest.cc

@@ -11,6 +11,7 @@

#include "content/public/test/mock_resource_context.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "content/test/test_content_browser_client.h"

+#include "net/base/request_priority.h"

#include "net/cert/x509_certificate.h"

#include "net/ssl/client_cert_store.h"

#include "net/ssl/ssl_cert_request_info.h"

@@ -211,9 +212,12 @@ TEST_F(ResourceLoaderTest, ClientCertStoreLookup) {

const int kRenderProcessId = 1;

const int kRenderViewId = 2;

- scoped_ptr<net::URLRequest> request(new net::URLRequest(

- GURL("dummy"), NULL,

- resource_context_.GetRequestContext()));

+ scoped_ptr<net::URLRequest> request(

+ new net::URLRequest(GURL("dummy"),

+ net::DEFAULT_PRIORITY,

+ NULL,

+ resource_context_.GetRequestContext(),

+ NULL));

mmenke 2013/10/30 15:27:11 Again, seems like we shouldn't be depending on res

akalin 2013/10/30 21:44:37 removed arg.

ResourceRequestInfo::AllocateForTesting(request.get(),

ResourceType::MAIN_FRAME,

&resource_context_,

@@ -275,7 +279,7 @@ TEST_F(ResourceLoaderTest, ClientCertStoreNull) {

const int kRenderViewId = 2;

scoped_ptr<net::URLRequest> request(new net::URLRequest(

- GURL("dummy"), NULL, resource_context_.GetRequestContext()));

+ GURL("dummy"), net::DEFAULT_PRIORITY, NULL, resource_context_.GetRequestContext(), NULL));

ResourceRequestInfo::AllocateForTesting(request.get(),

ResourceType::MAIN_FRAME,

&resource_context_,