Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2969)

Unified Diff: chrome/browser/ssl/ssl_client_certificate_selector_test.cc

Issue 51953002: [Net] Add a priority parameter to URLRequest's constructor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_client_certificate_selector_test.cc
diff --git a/chrome/browser/ssl/ssl_client_certificate_selector_test.cc b/chrome/browser/ssl/ssl_client_certificate_selector_test.cc
index da8e463d46f6dabe295a742ffac955468a8166b4..429980bb7d63f680ff04bdc4f7d4c77c9ee7dc03 100644
--- a/chrome/browser/ssl/ssl_client_certificate_selector_test.cc
+++ b/chrome/browser/ssl/ssl_client_certificate_selector_test.cc
@@ -12,6 +12,7 @@
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test_utils.h"
+#include "net/base/request_priority.h"
#include "net/base/test_data_directory.h"
#include "net/cert/x509_certificate.h"
#include "net/http/http_transaction_factory.h"
@@ -78,7 +79,7 @@ void SSLClientCertificateSelectorTestBase::CleanUpOnMainThread() {
}
void SSLClientCertificateSelectorTestBase::SetUpOnIOThread() {
- url_request_ = MakeURLRequest(url_request_context_getter_.get());
+ url_request_ = MakeURLRequest(url_request_context_getter_.get()).release();
auth_requestor_ = new StrictMock<SSLClientAuthRequestorMock>(
url_request_, cert_request_info_.get());
@@ -92,10 +93,11 @@ void SSLClientCertificateSelectorTestBase::CleanUpOnIOThread() {
io_loop_finished_event_.Signal();
}
-net::URLRequest* SSLClientCertificateSelectorTestBase::MakeURLRequest(
+scoped_ptr<net::URLRequest>
+SSLClientCertificateSelectorTestBase::MakeURLRequest(
net::URLRequestContextGetter* context_getter) {
- net::URLRequest* request =
+ scoped_ptr<net::URLRequest> request =
context_getter->GetURLRequestContext()->CreateRequest(
- GURL("https://example"), NULL);
- return request;
+ GURL("https://example"), net::DEFAULT_PRIORITY, NULL);
+ return request.Pass();
}

Powered by Google App Engine
This is Rietveld 408576698