Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc

Issue 51953002: [Net] Add a priority parameter to URLRequest's constructor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/files/file_path.h" 6 #include "base/files/file_path.h"
7 #include "base/synchronization/waitable_event.h" 7 #include "base/synchronization/waitable_event.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/ssl/ssl_client_auth_requestor_mock.h" 9 #include "chrome/browser/ssl/ssl_client_auth_requestor_mock.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/tabs/tab_strip_model.h" 11 #include "chrome/browser/ui/tabs/tab_strip_model.h"
12 #include "chrome/browser/ui/views/ssl_client_certificate_selector.h" 12 #include "chrome/browser/ui/views/ssl_client_certificate_selector.h"
13 #include "chrome/test/base/in_process_browser_test.h" 13 #include "chrome/test/base/in_process_browser_test.h"
14 #include "chrome/test/base/interactive_test_utils.h" 14 #include "chrome/test/base/interactive_test_utils.h"
15 #include "chrome/test/base/ui_test_utils.h" 15 #include "chrome/test/base/ui_test_utils.h"
16 #include "content/public/browser/web_contents.h" 16 #include "content/public/browser/web_contents.h"
17 #include "content/public/test/browser_test_utils.h" 17 #include "content/public/test/browser_test_utils.h"
18 #include "net/base/request_priority.h"
18 #include "net/base/test_data_directory.h" 19 #include "net/base/test_data_directory.h"
19 #include "net/cert/x509_certificate.h" 20 #include "net/cert/x509_certificate.h"
20 #include "net/http/http_transaction_factory.h" 21 #include "net/http/http_transaction_factory.h"
21 #include "net/ssl/ssl_cert_request_info.h" 22 #include "net/ssl/ssl_cert_request_info.h"
22 #include "net/test/cert_test_util.h" 23 #include "net/test/cert_test_util.h"
23 #include "net/url_request/url_request.h" 24 #include "net/url_request/url_request.h"
24 #include "net/url_request/url_request_context.h" 25 #include "net/url_request/url_request_context.h"
25 #include "net/url_request/url_request_context_getter.h" 26 #include "net/url_request/url_request_context_getter.h"
26 #include "testing/gtest/include/gtest/gtest.h" 27 #include "testing/gtest/include/gtest/gtest.h"
27 28
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 auth_requestor_->http_network_session_, 75 auth_requestor_->http_network_session_,
75 auth_requestor_->cert_request_info_, 76 auth_requestor_->cert_request_info_,
76 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected, 77 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
77 auth_requestor_)); 78 auth_requestor_));
78 selector_->Init(); 79 selector_->Init();
79 80
80 EXPECT_EQ(mit_davidben_cert_.get(), selector_->GetSelectedCert()); 81 EXPECT_EQ(mit_davidben_cert_.get(), selector_->GetSelectedCert());
81 } 82 }
82 83
83 virtual void SetUpOnIOThread() { 84 virtual void SetUpOnIOThread() {
84 url_request_ = MakeURLRequest(url_request_context_getter_); 85 url_request_ = MakeURLRequest(url_request_context_getter_).release();
85 86
86 auth_requestor_ = new StrictMock<SSLClientAuthRequestorMock>( 87 auth_requestor_ = new StrictMock<SSLClientAuthRequestorMock>(
87 url_request_, 88 url_request_,
88 cert_request_info_); 89 cert_request_info_);
89 90
90 io_loop_finished_event_.Signal(); 91 io_loop_finished_event_.Signal();
91 } 92 }
92 93
93 // Have to release our reference to the auth handler during the test to allow 94 // Have to release our reference to the auth handler during the test to allow
94 // it to be destroyed while the Browser and its IO thread still exist. 95 // it to be destroyed while the Browser and its IO thread still exist.
95 virtual void CleanUpOnMainThread() OVERRIDE { 96 virtual void CleanUpOnMainThread() OVERRIDE {
96 BrowserThread::PostTask( 97 BrowserThread::PostTask(
97 BrowserThread::IO, FROM_HERE, 98 BrowserThread::IO, FROM_HERE,
98 base::Bind(&SSLClientCertificateSelectorTest::CleanUpOnIOThread, this)); 99 base::Bind(&SSLClientCertificateSelectorTest::CleanUpOnIOThread, this));
99 100
100 io_loop_finished_event_.Wait(); 101 io_loop_finished_event_.Wait();
101 102
102 auth_requestor_ = NULL; 103 auth_requestor_ = NULL;
103 } 104 }
104 105
105 virtual void CleanUpOnIOThread() { 106 virtual void CleanUpOnIOThread() {
106 delete url_request_; 107 delete url_request_;
107 108
108 io_loop_finished_event_.Signal(); 109 io_loop_finished_event_.Signal();
109 } 110 }
110 111
111 protected: 112 protected:
112 net::URLRequest* MakeURLRequest( 113 scoped_ptr<net::URLRequest> MakeURLRequest(
113 net::URLRequestContextGetter* context_getter) { 114 net::URLRequestContextGetter* context_getter) {
114 net::URLRequest* request = 115 return context_getter->GetURLRequestContext()->CreateRequest(
115 context_getter->GetURLRequestContext()->CreateRequest( 116 GURL("https://example"), net::DEFAULT_PRIORITY, NULL);
116 GURL("https://example"), NULL);
117 return request;
118 } 117 }
119 118
120 base::WaitableEvent io_loop_finished_event_; 119 base::WaitableEvent io_loop_finished_event_;
121 120
122 scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_; 121 scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
123 net::URLRequest* url_request_; 122 net::URLRequest* url_request_;
124 123
125 scoped_refptr<net::X509Certificate> mit_davidben_cert_; 124 scoped_refptr<net::X509Certificate> mit_davidben_cert_;
126 scoped_refptr<net::X509Certificate> foaf_me_chromium_test_cert_; 125 scoped_refptr<net::X509Certificate> foaf_me_chromium_test_cert_;
127 scoped_refptr<net::SSLCertRequestInfo> cert_request_info_; 126 scoped_refptr<net::SSLCertRequestInfo> cert_request_info_;
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected, 172 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
174 auth_requestor_2_)); 173 auth_requestor_2_));
175 selector_2_->Init(); 174 selector_2_->Init();
176 175
177 EXPECT_EQ(2, browser()->tab_strip_model()->active_index()); 176 EXPECT_EQ(2, browser()->tab_strip_model()->active_index());
178 EXPECT_EQ(mit_davidben_cert_.get(), selector_1_->GetSelectedCert()); 177 EXPECT_EQ(mit_davidben_cert_.get(), selector_1_->GetSelectedCert());
179 EXPECT_EQ(mit_davidben_cert_.get(), selector_2_->GetSelectedCert()); 178 EXPECT_EQ(mit_davidben_cert_.get(), selector_2_->GetSelectedCert());
180 } 179 }
181 180
182 virtual void SetUpOnIOThread() OVERRIDE { 181 virtual void SetUpOnIOThread() OVERRIDE {
183 url_request_1_ = MakeURLRequest(url_request_context_getter_); 182 url_request_1_ = MakeURLRequest(url_request_context_getter_).release();
184 url_request_2_ = MakeURLRequest(url_request_context_getter_); 183 url_request_2_ = MakeURLRequest(url_request_context_getter_).release();
185 184
186 auth_requestor_1_ = new StrictMock<SSLClientAuthRequestorMock>( 185 auth_requestor_1_ = new StrictMock<SSLClientAuthRequestorMock>(
187 url_request_1_, 186 url_request_1_,
188 cert_request_info_1_); 187 cert_request_info_1_);
189 auth_requestor_2_ = new StrictMock<SSLClientAuthRequestorMock>( 188 auth_requestor_2_ = new StrictMock<SSLClientAuthRequestorMock>(
190 url_request_2_, 189 url_request_2_,
191 cert_request_info_2_); 190 cert_request_info_2_);
192 191
193 SSLClientCertificateSelectorTest::SetUpOnIOThread(); 192 SSLClientCertificateSelectorTest::SetUpOnIOThread();
194 } 193 }
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 auth_requestor_1_->http_network_session_, 239 auth_requestor_1_->http_network_session_,
241 auth_requestor_1_->cert_request_info_, 240 auth_requestor_1_->cert_request_info_,
242 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected, 241 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
243 auth_requestor_1_)); 242 auth_requestor_1_));
244 selector_1_->Init(); 243 selector_1_->Init();
245 244
246 EXPECT_EQ(mit_davidben_cert_.get(), selector_1_->GetSelectedCert()); 245 EXPECT_EQ(mit_davidben_cert_.get(), selector_1_->GetSelectedCert());
247 } 246 }
248 247
249 virtual void SetUpOnIOThread() OVERRIDE { 248 virtual void SetUpOnIOThread() OVERRIDE {
250 url_request_1_ = MakeURLRequest(url_request_context_getter_1_); 249 url_request_1_ = MakeURLRequest(url_request_context_getter_1_).release();
251 250
252 auth_requestor_1_ = new StrictMock<SSLClientAuthRequestorMock>( 251 auth_requestor_1_ = new StrictMock<SSLClientAuthRequestorMock>(
253 url_request_1_, 252 url_request_1_,
254 cert_request_info_1_); 253 cert_request_info_1_);
255 254
256 SSLClientCertificateSelectorTest::SetUpOnIOThread(); 255 SSLClientCertificateSelectorTest::SetUpOnIOThread();
257 } 256 }
258 257
259 virtual void CleanUpOnMainThread() OVERRIDE { 258 virtual void CleanUpOnMainThread() OVERRIDE {
260 auth_requestor_1_ = NULL; 259 auth_requestor_1_ = NULL;
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 EXPECT_TRUE(ui_test_utils::SendKeyPressSync( 377 EXPECT_TRUE(ui_test_utils::SendKeyPressSync(
379 browser_1_, ui::VKEY_RETURN, false, false, false, false)); 378 browser_1_, ui::VKEY_RETURN, false, false, false, false));
380 379
381 Mock::VerifyAndClear(auth_requestor_.get()); 380 Mock::VerifyAndClear(auth_requestor_.get());
382 Mock::VerifyAndClear(auth_requestor_1_.get()); 381 Mock::VerifyAndClear(auth_requestor_1_.get());
383 382
384 // Now let the default selection for auth_requestor_ mock get checked on 383 // Now let the default selection for auth_requestor_ mock get checked on
385 // destruction. 384 // destruction.
386 EXPECT_CALL(*auth_requestor_, CertificateSelected(NULL)); 385 EXPECT_CALL(*auth_requestor_, CertificateSelected(NULL));
387 } 386 }
OLDNEW
« no previous file with comments | « chrome/browser/ssl/ssl_client_certificate_selector_test.cc ('k') | chrome_frame/test/test_server_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698