Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

Issue 51953002: [Net] Add a priority parameter to URLRequest's constructor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/web_request/web_request_permissions.h" 5 #include "chrome/browser/extensions/api/web_request/web_request_permissions.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "chrome/browser/extensions/extension_info_map.h" 8 #include "chrome/browser/extensions/extension_info_map.h"
9 #include "chrome/common/extensions/extension_constants.h" 9 #include "chrome/common/extensions/extension_constants.h"
10 #include "chrome/common/extensions/extension_test_util.h" 10 #include "chrome/common/extensions/extension_test_util.h"
11 #include "chrome/test/base/testing_profile.h" 11 #include "chrome/test/base/testing_profile.h"
12 #include "content/public/browser/resource_request_info.h" 12 #include "content/public/browser/resource_request_info.h"
13 #include "content/public/test/test_browser_thread_bundle.h" 13 #include "content/public/test/test_browser_thread_bundle.h"
14 #include "net/base/request_priority.h"
14 #include "net/url_request/url_request_test_util.h" 15 #include "net/url_request/url_request_test_util.h"
15 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
16 17
17 using content::ResourceRequestInfo; 18 using content::ResourceRequestInfo;
18 using extensions::Extension; 19 using extensions::Extension;
19 using extensions::Manifest; 20 using extensions::Manifest;
20 using extension_test_util::LoadManifestUnchecked; 21 using extension_test_util::LoadManifestUnchecked;
21 22
22 class ExtensionWebRequestHelpersTestWithThreadsTest : public testing::Test { 23 class ExtensionWebRequestHelpersTestWithThreadsTest : public testing::Test {
23 public: 24 public:
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 }; 84 };
84 const char* non_sensitive_urls[] = { 85 const char* non_sensitive_urls[] = {
85 "http://www.google.com/" 86 "http://www.google.com/"
86 }; 87 };
87 const int kSigninProcessId = 99; 88 const int kSigninProcessId = 99;
88 extension_info_map_->SetSigninProcess(kSigninProcessId); 89 extension_info_map_->SetSigninProcess(kSigninProcessId);
89 90
90 // Check that requests are rejected based on the destination 91 // Check that requests are rejected based on the destination
91 for (size_t i = 0; i < arraysize(sensitive_urls); ++i) { 92 for (size_t i = 0; i < arraysize(sensitive_urls); ++i) {
92 GURL sensitive_url(sensitive_urls[i]); 93 GURL sensitive_url(sensitive_urls[i]);
93 net::TestURLRequest request(sensitive_url, NULL, &context, NULL); 94 net::TestURLRequest request(
95 sensitive_url, net::DEFAULT_PRIORITY, NULL, &context);
94 EXPECT_TRUE( 96 EXPECT_TRUE(
95 WebRequestPermissions::HideRequest(extension_info_map_.get(), &request)) 97 WebRequestPermissions::HideRequest(extension_info_map_.get(), &request))
96 << sensitive_urls[i]; 98 << sensitive_urls[i];
97 } 99 }
98 // Check that requests are accepted if they don't touch sensitive urls. 100 // Check that requests are accepted if they don't touch sensitive urls.
99 for (size_t i = 0; i < arraysize(non_sensitive_urls); ++i) { 101 for (size_t i = 0; i < arraysize(non_sensitive_urls); ++i) {
100 GURL non_sensitive_url(non_sensitive_urls[i]); 102 GURL non_sensitive_url(non_sensitive_urls[i]);
101 net::TestURLRequest request(non_sensitive_url, NULL, &context, NULL); 103 net::TestURLRequest request(
104 non_sensitive_url, net::DEFAULT_PRIORITY, NULL, &context);
102 EXPECT_FALSE( 105 EXPECT_FALSE(
103 WebRequestPermissions::HideRequest(extension_info_map_.get(), &request)) 106 WebRequestPermissions::HideRequest(extension_info_map_.get(), &request))
104 << non_sensitive_urls[i]; 107 << non_sensitive_urls[i];
105 } 108 }
106 109
107 // Check protection of requests originating from the frame showing the Chrome 110 // Check protection of requests originating from the frame showing the Chrome
108 // WebStore. 111 // WebStore.
109 // Normally this request is not protected: 112 // Normally this request is not protected:
110 GURL non_sensitive_url("http://www.google.com/test.js"); 113 GURL non_sensitive_url("http://www.google.com/test.js");
111 net::TestURLRequest non_sensitive_request( 114 net::TestURLRequest non_sensitive_request(
112 non_sensitive_url, NULL, &context, NULL); 115 non_sensitive_url, net::DEFAULT_PRIORITY, NULL, &context);
113 EXPECT_FALSE(WebRequestPermissions::HideRequest(extension_info_map_.get(), 116 EXPECT_FALSE(WebRequestPermissions::HideRequest(extension_info_map_.get(),
114 &non_sensitive_request)); 117 &non_sensitive_request));
115 // If the origin is labeled by the WebStoreAppId, it becomes protected. 118 // If the origin is labeled by the WebStoreAppId, it becomes protected.
116 { 119 {
117 int process_id = 42; 120 int process_id = 42;
118 int site_instance_id = 23; 121 int site_instance_id = 23;
119 int frame_id = 17; 122 int frame_id = 17;
120 net::TestURLRequest sensitive_request( 123 net::TestURLRequest sensitive_request(
121 non_sensitive_url, NULL, &context, NULL); 124 non_sensitive_url, net::DEFAULT_PRIORITY, NULL, &context);
122 ResourceRequestInfo::AllocateForTesting( 125 ResourceRequestInfo::AllocateForTesting(
123 &sensitive_request, ResourceType::SCRIPT, NULL, 126 &sensitive_request, ResourceType::SCRIPT, NULL,
124 process_id, frame_id, false); 127 process_id, frame_id, false);
125 extension_info_map_->RegisterExtensionProcess( 128 extension_info_map_->RegisterExtensionProcess(
126 extension_misc::kWebStoreAppId, process_id, site_instance_id); 129 extension_misc::kWebStoreAppId, process_id, site_instance_id);
127 EXPECT_TRUE(WebRequestPermissions::HideRequest(extension_info_map_.get(), 130 EXPECT_TRUE(WebRequestPermissions::HideRequest(extension_info_map_.get(),
128 &sensitive_request)); 131 &sensitive_request));
129 } 132 }
130 // If the process is the signin process, it becomes protected. 133 // If the process is the signin process, it becomes protected.
131 { 134 {
132 int process_id = kSigninProcessId; 135 int process_id = kSigninProcessId;
133 int frame_id = 19; 136 int frame_id = 19;
134 net::TestURLRequest sensitive_request( 137 net::TestURLRequest sensitive_request(
135 non_sensitive_url, NULL, &context, NULL); 138 non_sensitive_url, net::DEFAULT_PRIORITY, NULL, &context);
136 ResourceRequestInfo::AllocateForTesting( 139 ResourceRequestInfo::AllocateForTesting(
137 &sensitive_request, ResourceType::SCRIPT, NULL, 140 &sensitive_request, ResourceType::SCRIPT, NULL,
138 process_id, frame_id, false); 141 process_id, frame_id, false);
139 EXPECT_TRUE(WebRequestPermissions::HideRequest(extension_info_map_.get(), 142 EXPECT_TRUE(WebRequestPermissions::HideRequest(extension_info_map_.get(),
140 &sensitive_request)); 143 &sensitive_request));
141 } 144 }
142 } 145 }
143 146
144 TEST_F(ExtensionWebRequestHelpersTestWithThreadsTest, 147 TEST_F(ExtensionWebRequestHelpersTestWithThreadsTest,
145 TestCanExtensionAccessURL_HostPermissions) { 148 TestCanExtensionAccessURL_HostPermissions) {
146 net::TestURLRequest request( 149 net::TestURLRequest request(
147 GURL("http://example.com"), NULL, &context, NULL); 150 GURL("http://example.com"), net::DEFAULT_PRIORITY, NULL, &context);
148 151
149 EXPECT_TRUE(WebRequestPermissions::CanExtensionAccessURL( 152 EXPECT_TRUE(WebRequestPermissions::CanExtensionAccessURL(
150 extension_info_map_.get(), 153 extension_info_map_.get(),
151 permissionless_extension_->id(), 154 permissionless_extension_->id(),
152 request.url(), 155 request.url(),
153 false /*crosses_incognito*/, 156 false /*crosses_incognito*/,
154 WebRequestPermissions::DO_NOT_CHECK_HOST)); 157 WebRequestPermissions::DO_NOT_CHECK_HOST));
155 EXPECT_FALSE(WebRequestPermissions::CanExtensionAccessURL( 158 EXPECT_FALSE(WebRequestPermissions::CanExtensionAccessURL(
156 extension_info_map_.get(), 159 extension_info_map_.get(),
157 permissionless_extension_->id(), 160 permissionless_extension_->id(),
158 request.url(), 161 request.url(),
159 false /*crosses_incognito*/, 162 false /*crosses_incognito*/,
160 WebRequestPermissions::REQUIRE_HOST_PERMISSION)); 163 WebRequestPermissions::REQUIRE_HOST_PERMISSION));
161 EXPECT_TRUE(WebRequestPermissions::CanExtensionAccessURL( 164 EXPECT_TRUE(WebRequestPermissions::CanExtensionAccessURL(
162 extension_info_map_.get(), 165 extension_info_map_.get(),
163 com_extension_->id(), 166 com_extension_->id(),
164 request.url(), 167 request.url(),
165 false /*crosses_incognito*/, 168 false /*crosses_incognito*/,
166 WebRequestPermissions::REQUIRE_HOST_PERMISSION)); 169 WebRequestPermissions::REQUIRE_HOST_PERMISSION));
167 EXPECT_FALSE(WebRequestPermissions::CanExtensionAccessURL( 170 EXPECT_FALSE(WebRequestPermissions::CanExtensionAccessURL(
168 extension_info_map_.get(), 171 extension_info_map_.get(),
169 com_extension_->id(), 172 com_extension_->id(),
170 request.url(), 173 request.url(),
171 false /*crosses_incognito*/, 174 false /*crosses_incognito*/,
172 WebRequestPermissions::REQUIRE_ALL_URLS)); 175 WebRequestPermissions::REQUIRE_ALL_URLS));
173 } 176 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698