Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/gpu/effects/GrBezierEffect.cpp

Issue 519473003: Use highp for gpu bezier effects (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Use highp on cubics only Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/gl/builders/GrGLShaderBuilder.h » ('j') | src/gpu/gl/builders/GrGLShaderBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/effects/GrBezierEffect.cpp
diff --git a/src/gpu/effects/GrBezierEffect.cpp b/src/gpu/effects/GrBezierEffect.cpp
index 7384f62856c91378014f114d3fdee8c026a8e02a..906155640bcfdaf07fae5768c05babb6990a0b24 100644
--- a/src/gpu/effects/GrBezierEffect.cpp
+++ b/src/gpu/effects/GrBezierEffect.cpp
@@ -60,56 +60,90 @@ void GrGLConicEffect::emitCode(GrGLFullProgramBuilder* builder,
vsBuilder->codeAppendf("\t%s = %s;\n", vsName, attr0Name->c_str());
GrGLFragmentShaderBuilder* fsBuilder = builder->getFragmentShaderBuilder();
- fsBuilder->codeAppend("\t\tfloat edgeAlpha;\n");
+
+ GrGLShaderVar edgeAlpha("edgeAlpha", kFloat_GrSLType, 0, GrGLShaderVar::kHigh_Precision);
+ GrGLShaderVar dklmdx("dklmdx", kVec3f_GrSLType, 0, GrGLShaderVar::kHigh_Precision);
+ GrGLShaderVar dklmdy("dklmdy", kVec3f_GrSLType, 0, GrGLShaderVar::kHigh_Precision);
+ GrGLShaderVar dfdx("dfdx", kFloat_GrSLType, 0, GrGLShaderVar::kHigh_Precision);
+ GrGLShaderVar dfdy("dfdy", kFloat_GrSLType, 0, GrGLShaderVar::kHigh_Precision);
+ GrGLShaderVar gF("gF", kVec2f_GrSLType, 0, GrGLShaderVar::kHigh_Precision);
+ GrGLShaderVar gFM("gFM", kFloat_GrSLType, 0, GrGLShaderVar::kHigh_Precision);
+ GrGLShaderVar func("func", kFloat_GrSLType, 0, GrGLShaderVar::kHigh_Precision);
+
+ fsBuilder->declAppend(edgeAlpha);
+ fsBuilder->declAppend(dklmdx);
+ fsBuilder->declAppend(dklmdy);
+ fsBuilder->declAppend(dfdx);
+ fsBuilder->declAppend(dfdy);
+ fsBuilder->declAppend(gF);
+ fsBuilder->declAppend(gFM);
+ fsBuilder->declAppend(func);
switch (fEdgeType) {
case kHairlineAA_GrEffectEdgeType: {
SkAssertResult(fsBuilder->enableFeature(
GrGLFragmentShaderBuilder::kStandardDerivatives_GLSLFeature));
- fsBuilder->codeAppendf("\t\tvec3 dklmdx = dFdx(%s.xyz);\n", fsName);
- fsBuilder->codeAppendf("\t\tvec3 dklmdy = dFdy(%s.xyz);\n", fsName);
- fsBuilder->codeAppendf("\t\tfloat dfdx =\n"
- "\t\t\t2.0*%s.x*dklmdx.x - %s.y*dklmdx.z - %s.z*dklmdx.y;\n",
- fsName, fsName, fsName);
- fsBuilder->codeAppendf("\t\tfloat dfdy =\n"
- "\t\t\t2.0*%s.x*dklmdy.x - %s.y*dklmdy.z - %s.z*dklmdy.y;\n",
- fsName, fsName, fsName);
- fsBuilder->codeAppend("\t\tvec2 gF = vec2(dfdx, dfdy);\n");
- fsBuilder->codeAppend("\t\tfloat gFM = sqrt(dot(gF, gF));\n");
- fsBuilder->codeAppendf("\t\tfloat func = %s.x*%s.x - %s.y*%s.z;\n", fsName, fsName,
- fsName, fsName);
- fsBuilder->codeAppend("\t\tfunc = abs(func);\n");
- fsBuilder->codeAppend("\t\tedgeAlpha = func / gFM;\n");
- fsBuilder->codeAppend("\t\tedgeAlpha = max(1.0 - edgeAlpha, 0.0);\n");
+ fsBuilder->codeAppendf("\t\t%s = dFdx(%s.xyz);\n", dklmdx.c_str(), fsName);
+ fsBuilder->codeAppendf("\t\t%s = dFdy(%s.xyz);\n", dklmdy.c_str(), fsName);
+ fsBuilder->codeAppendf("\t\t%s =\n"
+ "\t\t\t2.0 * %s.x * %s.x - %s.y * %s.z - %s.z * %s.y;\n",
+ dfdx.c_str(), fsName, dklmdx.c_str(), fsName, dklmdx.c_str(),
+ fsName, dklmdx.c_str());
+ fsBuilder->codeAppendf("\t\t%s =\n"
+ "\t\t\t2.0 * %s.x * %s.x - %s.y * %s.z - %s.z * %s.y;\n",
+ dfdy.c_str(), fsName, dklmdy.c_str(), fsName, dklmdy.c_str(),
+ fsName, dklmdy.c_str());
+ fsBuilder->codeAppendf("\t\t%s = vec2(%s, %s);\n",
+ gF.c_str(), dfdx.c_str(), dfdy.c_str());
+ fsBuilder->codeAppendf("\t\t%s = sqrt(dot(%s, %s));\n",
+ gFM.c_str(), gF.c_str(), gF.c_str());
+ fsBuilder->codeAppendf("\t\t%s = %s.x*%s.x - %s.y*%s.z;\n",
+ func.c_str(), fsName, fsName, fsName, fsName);
+ fsBuilder->codeAppendf("\t\t%s = abs(%s);\n", func.c_str(), func.c_str());
+ fsBuilder->codeAppendf("\t\t%s = %s / %s;\n",
+ edgeAlpha.c_str(), func.c_str(), gFM.c_str());
+ fsBuilder->codeAppendf("\t\t%s = max(1.0 - %s, 0.0);\n",
+ edgeAlpha.c_str(), edgeAlpha.c_str());
// Add line below for smooth cubic ramp
- // fsBuilder->codeAppend("\t\tedgeAlpha = edgeAlpha*edgeAlpha*(3.0-2.0*edgeAlpha);\n");
+ // fsBuilder->codeAppendf("\t\t%s = %s * %s * (3.0 - 2.0 * %s);\n",
+ // edgeAlpha.c_str(), edgeAlpha.c_str(), edgeAlpha.c_str(),
+ // edgeAlpha.c_str());
break;
}
case kFillAA_GrEffectEdgeType: {
SkAssertResult(fsBuilder->enableFeature(
GrGLFragmentShaderBuilder::kStandardDerivatives_GLSLFeature));
- fsBuilder->codeAppendf("\t\tvec3 dklmdx = dFdx(%s.xyz);\n", fsName);
- fsBuilder->codeAppendf("\t\tvec3 dklmdy = dFdy(%s.xyz);\n", fsName);
- fsBuilder->codeAppendf("\t\tfloat dfdx =\n"
- "\t\t\t2.0*%s.x*dklmdx.x - %s.y*dklmdx.z - %s.z*dklmdx.y;\n",
- fsName, fsName, fsName);
- fsBuilder->codeAppendf("\t\tfloat dfdy =\n"
- "\t\t\t2.0*%s.x*dklmdy.x - %s.y*dklmdy.z - %s.z*dklmdy.y;\n",
- fsName, fsName, fsName);
- fsBuilder->codeAppend("\t\tvec2 gF = vec2(dfdx, dfdy);\n");
- fsBuilder->codeAppend("\t\tfloat gFM = sqrt(dot(gF, gF));\n");
- fsBuilder->codeAppendf("\t\tfloat func = %s.x*%s.x - %s.y*%s.z;\n", fsName, fsName,
- fsName, fsName);
- fsBuilder->codeAppend("\t\tedgeAlpha = func / gFM;\n");
- fsBuilder->codeAppend("\t\tedgeAlpha = clamp(1.0 - edgeAlpha, 0.0, 1.0);\n");
+ fsBuilder->codeAppendf("\t\t%s = dFdx(%s.xyz);\n", dklmdx.c_str(), fsName);
+ fsBuilder->codeAppendf("\t\t%s = dFdy(%s.xyz);\n", dklmdy.c_str(), fsName);
+ fsBuilder->codeAppendf("\t\t%s =\n"
+ "\t\t\t2.0 * %s.x * %s.x - %s.y * %s.z - %s.z * %s.y;\n",
+ dfdx.c_str(), fsName, dklmdx.c_str(), fsName, dklmdx.c_str(),
+ fsName, dklmdx.c_str());
+ fsBuilder->codeAppendf("\t\t%s =\n"
+ "\t\t\t2.0 * %s.x * %s.x - %s.y * %s.z - %s.z * %s.y;\n",
+ dfdy.c_str(), fsName, dklmdy.c_str(), fsName, dklmdy.c_str(),
+ fsName, dklmdy.c_str());
+ fsBuilder->codeAppendf("\t\t%s = vec2(%s, %s);\n",
+ gF.c_str(), dfdx.c_str(), dfdy.c_str());
+ fsBuilder->codeAppendf("\t\t%s = sqrt(dot(%s, %s));\n",
+ gFM.c_str(), gF.c_str(), gF.c_str());
+ fsBuilder->codeAppendf("\t\t%s = %s.x*%s.x - %s.y*%s.z;\n",
+ func.c_str(), fsName, fsName, fsName, fsName);
+ fsBuilder->codeAppendf("\t\t%s = %s / %s;\n",
+ edgeAlpha.c_str(), func.c_str(), gFM.c_str());
+ fsBuilder->codeAppendf("\t\t%s = clamp(1.0 - %s, 0.0, 1.0);\n",
+ edgeAlpha.c_str(), edgeAlpha.c_str());
// Add line below for smooth cubic ramp
- // fsBuilder->codeAppend("\t\tedgeAlpha = edgeAlpha*edgeAlpha*(3.0-2.0*edgeAlpha);\n");
+ // fsBuilder->codeAppendf("\t\t%s = %s * %s * (3.0 - 2.0 * %s);\n",
+ // edgeAlpha.c_str(), edgeAlpha.c_str(), edgeAlpha.c_str(),
+ // edgeAlpha.c_str());
break;
}
case kFillBW_GrEffectEdgeType: {
- fsBuilder->codeAppendf("\t\tedgeAlpha = %s.x*%s.x - %s.y*%s.z;\n", fsName, fsName,
- fsName, fsName);
- fsBuilder->codeAppend("\t\tedgeAlpha = float(edgeAlpha < 0.0);\n");
+ fsBuilder->codeAppendf("\t\t%s = %s.x*%s.x - %s.y*%s.z;\n",
+ edgeAlpha.c_str(), fsName, fsName, fsName, fsName);
+ fsBuilder->codeAppendf("\t\t%s = float(%s < 0.0);\n",
+ edgeAlpha.c_str(), edgeAlpha.c_str());
break;
}
default:
@@ -117,7 +151,7 @@ void GrGLConicEffect::emitCode(GrGLFullProgramBuilder* builder,
}
fsBuilder->codeAppendf("\t%s = %s;\n", outputColor,
- (GrGLSLExpr4(inputColor) * GrGLSLExpr1("edgeAlpha")).c_str());
+ (GrGLSLExpr4(inputColor) * GrGLSLExpr1(edgeAlpha.c_str())).c_str());
}
void GrGLConicEffect::GenKey(const GrDrawEffect& drawEffect, const GrGLCaps&,
« no previous file with comments | « no previous file | src/gpu/gl/builders/GrGLShaderBuilder.h » ('j') | src/gpu/gl/builders/GrGLShaderBuilder.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698